Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failOnWarning must be turned ON in eo-runtime #3663

Open
yegor256 opened this issue Dec 13, 2024 · 3 comments
Open

failOnWarning must be turned ON in eo-runtime #3663

yegor256 opened this issue Dec 13, 2024 · 3 comments
Assignees
@iri
Labels
bug good first issue help wanted

Comments

@yegor256
Copy link
Member

Currently, failOnWarning is set to false in eo-runtime/pom.xml. Let's put it to true and fix all warnings in .eo files: most of them are cosmetic.
iri added a commit to iri/eoc that referenced this issue Dec 17, 2024
@iri
Update README.md
dacb36c 
Added '--easy' flag to 'eoc' call. This is workaround until the 'failOnWarning' issue (objectionary/eo#3663) will be fixed. (inexperienced users with 'eo' who come for the first time and try to compile 'Hello world!' should not be discouraged)
@iri iri mentioned this issue Dec 17, 2024
Merged
@iri
Copy link
Contributor

iri commented Dec 17, 2024

I will take this.

@yegor256
Copy link
Member Author

@iri great! please, don't do it in one big pull request, to avoid risk of rejection.

@uchitsa uchitsa mentioned this issue Dec 17, 2024
Merged
@uchitsa
Copy link
Contributor

uchitsa commented Dec 17, 2024

@yegor256 I'm already started work on it and added some fixes. Please check PR #3692

github-merge-queue bot pushed a commit that referenced this issue Dec 25, 2024
@yegor256
Merge pull request #3754 from uchitsa/3663-fail-on-warning-on
bf2b212 
bug(#3663): fix warnings for failOnWarning turn ON
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2025
@yegor256
Merge pull request #3792 from uchitsa/3663-fail-on-warning-on
bdad472 
bug(#3663): fix warnings for failOnWarning turn ON
github-merge-queue bot pushed a commit that referenced this issue Jan 11, 2025
@yegor256
Merge pull request #3805 from uchitsa/3663-fail-on-warning-on
aa3bb87 
bug(#3663): fix warnings when failOnWarning switch on
yegor256 added a commit that referenced this issue Jan 16, 2025
@yegor256
Merge pull request #3819 from uchitsa/3663-fail-on-warning-on
0580d49 
bug(#3663): fix warnings for failOnWarning turn ON
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iri iri

Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iri @yegor256 @uchitsa