Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eo-maven-plugin allows attributes without names in an abstract object #3294

Closed
volodya-lombrozo opened this issue Jul 29, 2024 · 10 comments
Closed
Assignees
Labels

Comments

@volodya-lombrozo
Copy link
Member

The current version of eo-maven-plugin allows to declare attributes without names in abstract objects.

new-KClW ↦ ⟦
  Φ.org.eolang.int(
    α0 ↦ Φ.org.eolang.bytes(
      Δ ⤍ 00-00-00-00-00-00-00-00
    )
  )
⟧

new-KClW is an abstract object (as far as I know,) and the Φ.org.eolang.int is its attribute without a name. When I run xmir -> phi transformation, I don't see any errors, but I should. Attributes in abstract objects must have names.

If we ignore this issue, we will face with such errors.

I use the fooling plugin configuration in the project:

<plugin>
  <groupId>org.eolang</groupId>
  <artifactId>eo-maven-plugin</artifactId>
  <version>0.38.4</version>
  <executions>
    <execution>
      <id>convert-xmir-to-phi</id>
      <phase>process-classes</phase>
      <goals>
        <goal>xmir-to-phi</goal>
      </goals>
      <configuration>
        <phiInputDir>${project.build.directory}/generated-sources/opeo-decompile-modified-xmir</phiInputDir>
        <phiOutputDir>${project.build.directory}/generated-sources/phi-expressions</phiOutputDir>
      </configuration>
    </execution>
  </executions>
</plugin>
@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you take a look please?

Copy link

@volodya-lombrozo thanks for the report, here is a feedback:

Problems

  • The bug report is missing several crucial elements, reducing its effectiveness.
  • The title of the report is too broad and doesn't provide a succinct summary of the specific issue at hand.
  • The report fails to include the steps needed to replicate the problem, a necessary detail for developers to understand the issue thoroughly.

I would recommend adding a 'Steps to Reproduce' section to help developers recreate the issue on their end.

Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you release a new version, please?

@yegor256
Copy link
Member

@rultor release, tag is 0.39.0

@rultor
Copy link
Contributor

rultor commented Jul 29, 2024

@rultor release, tag is 0.39.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jul 29, 2024

@rultor release, tag is 0.39.0

@yegor256 Done! FYI, the full log is here (took me 14min)

@yegor256
Copy link
Member

@maxonfjvipon the problem in rultor was, as expected, in the size of the machine. Now, we are using AWS t2.xlarge and it all works.

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon How can I use the new version?

@yegor256
Copy link
Member

@volodya-lombrozo just change the version in the pom.xml. It doesn't work? Maybe it's better to report a new ticket, if it doesn't.

@volodya-lombrozo
Copy link
Member Author

@yegor256 Yes, changing version helps. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants