Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinarizeMojo does not add dependencies into EO code after unphi #3145

Closed
maxonfjvipon opened this issue Apr 25, 2024 · 3 comments · Fixed by #3161
Closed

BinarizeMojo does not add dependencies into EO code after unphi #3145

maxonfjvipon opened this issue Apr 25, 2024 · 3 comments · Fixed by #3161
Assignees
Labels

Comments

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Apr 25, 2024

It's EO test for rust object after phi -> unphi:

# This is the default 64+ symbols comment in front of named abstract object.
[] > rust-returns-positive-int
  Q
  .org
  .eolang
  .rust > r
    Q   
    .org      
    .eolang
    .string:0
      Q   
      .org   
      .eolang 
      .bytes:0
        75-73-65-20-65-6F-3A-3A-50-6F-72-74-61-6C-3B-0A-75-73-65-20-65-6F-3A-3A-65-6F-5F-65-6E-75-6D-3A-3A-45-4F-3B-0A-75-73-65-20-65-6F-3A-3A-65-6F-5F-65-6E-75-6D-$
    []:1
    Q
    .org
    .eolang
    .tuple 
    .empty:2
  $  
  .r
  .eq > @    
    Q
    .org
    .eolang
    .int:0   
      Q
      .org
      .eolang
      .bytes:0
        00-00-00-00-00-00-00-02

After it's parsed, optimized and verified BinarizeMojo does not add rust dependencies to it on binarize phase:

image
@maxonfjvipon
Copy link
Member Author

@levBagryansky please take this
blocks #3092

Copy link

@maxonfjvipon thanks for the report, here is a feedback:

Problems

  • The title is not succinct and clear: It uses specific terms (BinarizeMojo, unphi, phi) that may not be comprehensible to all developers.
  • The report does not provide clear steps to reproduce the issue: Including reproducible steps is a crucial part of a comprehensive bug report.
  • The report fails to provide the expected and actual outcomes: The expected and actual results should be included in the report to help developers discern the discrepancy and identify the bug.

Suggestions

  • Clear and Succinct Title: The title of the bug report should be concise and clear, which can give a quick understanding of the issue. It would be preferable to avoid using specific terms (BinarizeMojo, unphi, phi) that may not be comprehensible to all developers. A suggested title could be "Dependencies not added after code optimization process"
  • Steps to Reproduce: The bug report should include a clear and detailed step-by-step guide to reproduce the issue. This should include details such as the environment in which the bug occurred, the state of the system at the time, and the exact actions that led to the bug. Providing a reproducible test case would be extremely helpful.
  • Expected and Actual Results: To better understand the issue, the report should include both the expected and actual results. This will make it easier to identify the bug and find the root cause of the problem. For instance, "Expected result: The BinarizeMojo should add rust dependencies after the binarize phase. Actual result: The BinarizeMojo is not adding the rust dependencies".
  • Use of Screenshots: Instead of including a screenshot link, it would be better to describe the content or issue the screenshot is illustrating. Not everyone will have access to the linked resources or may have difficulties understanding the screenshot without context.
  • Avoid Technical Jargon: Unless it's required, try to limit the use of technical jargon. When you must use it, ensure you explain the terminology so that anyone reading the report can understand.
  • Report Formatting: The report could be improved with better formatting. Use markdown for code snippets and other formatting tools to improve readability.
  • Error messages: If there are any error messages associated with the bug, they should be included in the report. They can offer significant insights into the issue.

Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4

@maxonfjvipon
Copy link
Member Author

Such EO code, printed in reversed notation is also does not get dependencies:

# This is the default 64+ symbols comment in front of named abstract object.
[] > rust-returns-positive-int
  rust. > r
    eolang.
      org.
        Q
    string.:0
      eolang.
        org.
          Q
      bytes.:0
        eolang.
          org.
            Q
        75-73-65-20-65-6F-3A-3A-50-6F-72-74-61-6C-3B-0A-75-73-65-20-65-6F-3A-3A-65-6F-5F-65-6E-75-6D-3A-3A-45-4F-3B-0A-75-73-65-20-65-6F-3A-3A-65-6F-5F-65-6E-75-6D-$
    []:1
    empty.:2
      tuple.
        eolang.
          org.
            Q
  eq. > @
    r.
      $
    int.:0
      eolang.
        org.
          Q
      bytes.:0
        eolang.
          org.
            Q
        00-00-00-00-00-00-00-02

levBagryansky added a commit to levBagryansky/eo that referenced this issue May 2, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue May 3, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue May 3, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue May 6, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue May 6, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue May 6, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue May 6, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants