-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eo-runtime must not have ANY non-test dependencies #2684
Comments
@maxonfjvipon please, help us here |
@maxonfjvipon this should help, I believe: https://maven.apache.org/enforcer/enforcer-rules/banTransitiveDependencies.html |
@yegor256 we have |
@maxonfjvipon the flag works only for dependencies that are not eo-runtime. It works for those packages that we resolve, like eo-strings, etc. Thus, eo-runtime is unpackaged but its dependencies are ignored. This is the log I'm getting:
Here: https://github.com/objectionary/eo/actions/runs/7126950802/job/19405845463 |
@maxonfjvipon maybe the flag should also work for eo-runtime, but currently it doesn't |
@maxonfjvipon this bug holds this ticket: https://github.com/objectionary/normalizer-maven-plugin/issues/4 |
@rultor release, tag is |
The
resolve
goal in our plugin can't deal with JAR artifacts that have transitive dependencies. It simply ignores them. However,commons-text
was added to eo-runtime, by mistake. Let's 1) delete it from there, and 2) introduce a check into the build of eo-runtime (together with documentation) that would prevent this from happening in the future.The text was updated successfully, but these errors were encountered: