Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Δ attribute in tuple #2555

Closed
maxonfjvipon opened this issue Oct 25, 2023 · 7 comments · Fixed by #2559
Closed

Get rid of Δ attribute in tuple #2555

maxonfjvipon opened this issue Oct 25, 2023 · 7 comments · Fixed by #2559
Assignees

Comments

@maxonfjvipon
Copy link
Member

In order to resolve #2437 and leave Δ only in bytes we need to get rid of it on tuple.
Implementation of the tuple should be recursive and similar to implementation of tuple in LISP.

@maxonfjvipon maxonfjvipon self-assigned this Oct 26, 2023
@maxonfjvipon
Copy link
Member Author

New recursive realisation of tuple causes recursion between object tuple.length and int.plus:

[head tail] > tuple
  [] > length
    ^.head.length.plus 1 > @ # int.plus is called here
------
[] > int
  [x...] > plus /int # x is tuple here

In order to add up all the numbers of x we need to get x.length. And here we get recursion tuple.length -> int.plus -> tuple.length -> int.plus....
It can be resolved only if we get rid of varargs in int.plus object (and in all primitives in eo-runtime)

maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Oct 27, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Oct 27, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Oct 27, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Oct 29, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Oct 29, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Oct 29, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Oct 29, 2023
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Oct 29, 2023
@0pdd
Copy link

0pdd commented Oct 30, 2023

@maxonfjvipon 5 puzzles #2561, #2562, #2563, #2564, #2565 are still not solved.

@0pdd
Copy link

0pdd commented Nov 11, 2023

@maxonfjvipon 4 puzzles #2561, #2562, #2563, #2564 are still not solved; solved: #2565.

@0pdd
Copy link

0pdd commented Nov 20, 2023

@maxonfjvipon 3 puzzles #2561, #2562, #2563 are still not solved; solved: #2564, #2565.

@0pdd
Copy link

0pdd commented Nov 23, 2023

@maxonfjvipon 2 puzzles #2561, #2563 are still not solved; solved: #2562, #2564, #2565.

@0pdd
Copy link

0pdd commented Nov 29, 2023

@maxonfjvipon the puzzle #2561 is still not solved; solved: #2562, #2563, #2564, #2565.

@0pdd
Copy link

0pdd commented Dec 22, 2023

@maxonfjvipon all 5 puzzles are solved here: #2561, #2562, #2563, #2564, #2565.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants