-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
517 fix stream rules incorrectly modify the code produced by the opeo-maven-plugin #519
517 fix stream rules incorrectly modify the code produced by the opeo-maven-plugin #519
Conversation
This reverts commit a5120e1.
@deemp I believe the example should be changed, not the rule. Since we have changed the rule to match the actual output of |
@fizruk, why don't we use
eo-phi-normalizer/eo-phi-normalizer/test/eo/phi/rules/streams.yaml Lines 15 to 22 in a150fd9
|
@deemp |
I think you should add a more realistic example from #470 to the tests here. |
@fizruk, I ran input: |
⟦
α0 ↦ Φ.org.eolang.checkcast(
α1 ↦ ξ.java.util.stream.j$Stream.java_util_stream_Stream$of(
α0 ↦ Φ.org.eolang.string,
α1 ↦ ξ.ref-avilqrqcdj.write-array
).java_util_stream_Stream$map(
α0 ↦ Φ.org.eolang.string,
α1 ↦ Φ.org.eolang.labeled
).java_lang_Object$collect(
α0 ↦ Φ.org.eolang.string,
α1 ↦ ξ.java.util.stream.j$Collectors.java_util_stream_Collector$joining
)
),
⟧
output:
- |
⟦
α0 ↦ Φ.org.eolang.checkcast (α1 ↦ ⟦
foreach_body$1 ↦ ξ.java.util.stream.j$Stream.java_util_stream_Stream$of (α0 ↦ Φ.org.eolang.string, α1 ↦ ξ.ref-avilqrqcdj.write-array),
java_util_stream_Stream$map_result$1 ↦ Φ.opeo.map-for-each (α0 ↦ ξ.foreach_body$1, α1 ↦ Φ.org.eolang.labeled),
φ ↦ ξ.java_util_stream_Stream$map_result$1.java_lang_Object$collect (α0 ↦ Φ.org.eolang.string, α1 ↦ ξ.java.util.stream.j$Collectors.java_util_stream_Collector$joining)
⟧.φ)
⟧
- |
⟦
α0 ↦ Φ.org.eolang.checkcast (α1 ↦ ⟦
foreach_body$1 ↦ ξ.java.util.stream.j$Stream.java_util_stream_Stream$of (α0 ↦ Φ.org.eolang.string, α1 ↦ ξ.ref-avilqrqcdj.write-array),
java_util_stream_Stream$map_result$1 ↦ Φ.opeo.map-for-each (α0 ↦ ξ.foreach_body$1, α1 ↦ Φ.org.eolang.labeled),
φ ↦ ξ.java_util_stream_Stream$map_result$1.java_lang_Object$collect
⟧.φ (α0 ↦ Φ.org.eolang.string, α1 ↦ ξ.java.util.stream.j$Collectors.java_util_stream_Collector$joining))
⟧
- |
⟦
α0 ↦ Φ.org.eolang.checkcast (α1 ↦ ⟦
foreach_body$1 ↦ ξ.java.util.stream.j$Stream.java_util_stream_Stream$of (α0 ↦ Φ.org.eolang.string, α1 ↦ ξ.ref-avilqrqcdj.write-array),
java_util_stream_Stream$map_result$1 ↦ Φ.opeo.map-for-each (α0 ↦ ξ.foreach_body$1, α1 ↦ Φ.org.eolang.labeled),
φ ↦ ξ.java_util_stream_Stream$map_result$1
⟧
.φ.java_lang_Object$collect (α0 ↦ Φ.org.eolang.string, α1 ↦ ξ.java.util.stream.j$Collectors.java_util_stream_Collector$joining))
⟧ |
opeo-maven-plugin
#517PR-Codex overview
This PR focuses on updating the naming conventions in the
streams.yaml
file to use the correct package names for Java streams, changingjava_util_Stream
tojava_util_stream_Stream
throughout the file.Detailed summary
forall
section, replacing!b2
with!b3
.!b1.java_util_Stream$map
to!b1.java_util_stream_Stream$map
.fresh
prefix fromjava_util_Stream$map_result
tojava_util_stream_Stream$map_result
.java_util_Stream$filter
andjava_util_Stream$toList
.