-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Implement missing/empty fields for MVP #289
Conversation
4286a23
to
eadefee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andy!
67ab076
to
c19dd29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending one comment.
Would appreciate if someone more familiar with the token logic could take a second pass through
18d985a
to
1af4b4e
Compare
Thank again, Andy. |
dfc65d6
to
8ab16d6
Compare
9037f01
to
4390ae3
Compare
Resolves #256
Implements all the fields that were added to the API in #247.
Most of the fields were straightforward, except for runtime balances. Changes introduced there:
accounts
module. #288 to implement tracking of oasis-sdk balances in runtimes/emerald/tokens
to/emerald/evm_tokens
; the former should be reserved for oasis-sdk tokens (currently only ROSE); internally renamedRuntimeToken
->EvmToken
/consensus/account
to return the balances across all paratimes, simultaneously for oasis-sdk tokens and EVM tokens.The last two points are not entirely coherent with each other: one splits the two kinds of tokens across two different URLs, while the other one unifies them. Both approaches have pluses and minuses; in the end, I decided for this combo because I think it best mirrors what the frontend needs, and we can always add endpoints that slice and dice and present (almost) the same information slightly differently.
I recommend reviewing commit by commit, as many of them are boilerplate.