Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track native balances in runtimes. Per-denomination events from accounts module. #288

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Track native balances in runtimes. Per-denomination events from accounts module. #288

merged 2 commits into from
Jan 25, 2023

Conversation

mitjat
Copy link
Contributor

@mitjat mitjat commented Jan 20, 2023

Pre-work for #256 . It turns out not all data was "readily available" :|

The PR brings two new features:

  • A table with dead-reckoned balances for "oasis-sdk native" runtime balances. This is separate from Warren's work on runtime balances, which tracks ERC-20 tokens and is limited to runtimes using the evm module. This PR is for runtimes using the accounts module, which so far is all of them.
  • Expands logged runtime events (transfers, burns, mints) to include the denomination, which we completely ignored so far. Right now all runtimes only have a single denomination (ROSE or TEST), but it would be painful to expand the APIs later.

@mitjat mitjat mentioned this pull request Jan 23, 2023
Merged
Andrew7234
Andrew7234 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@Andrew7234 Andrew7234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; hopefully Warren also has time to take a pass as well

analyzer/modules/consensusaccounts.go Outdated Show resolved Hide resolved
@mitjat mitjat force-pushed the mitjat/track-runtime-balance branch from 4286a23 to eadefee Compare January 25, 2023 20:41
@mitjat mitjat enabled auto-merge January 25, 2023 20:42
@mitjat mitjat merged commit e0f008b into main Jan 25, 2023
@mitjat mitjat deleted the mitjat/track-runtime-balance branch January 25, 2023 20:46
@pro-wh pro-wh mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew7234 Andrew7234 Andrew7234 approved these changes

@aefhm aefhm Awaiting requested review from aefhm

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitjat @Andrew7234