This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
[NSE-662] Add "like" expression support in WSCG #663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch depends on oap-project/arrow#66. |
This reverts commit 065547a.
Jenkins unit tests have been passed. And temporary commit have been reverted. @zhouyuan, please have a last check. |
zhouyuan
reviewed
Dec 30, 2021
} | ||
prepare_str_ += prepare_ss.str(); | ||
check_str_ = validity; | ||
header_list_.push_back(R"(#include "precompile/gandiva.h")"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this should be removed after the pre-compile header opt. Will follow up in the next PR
zhouyuan
pushed a commit
to zhouyuan/native-sql-engine
that referenced
this pull request
Dec 30, 2021
* Initial commit * Copy headers * Format the code * Change arrow branch for test [will revert at last] * Revert "Change arrow branch for test [will revert at last]" This reverts commit 065547a.
zhouyuan
added a commit
that referenced
this pull request
Dec 30, 2021
* [NSE-636]Remove log4j1 related unit tests (#646) * [NSE-640] Disable compression for tiny payloads in shuffle (#641) Closes #640 * [NSE-653] Add validity checking for get_json_object in WSCG (#654) * Initial commit * Add two unit test cases * Format the code * Update clang format check * [NSE-617] Handle exception in cast expression from string to numeric types in WSCG (#655) * [NSE-660] fix window builder with string (#649) * fix window builder with string Signed-off-by: Yuan Zhou <[email protected]> * fix format Signed-off-by: Yuan Zhou <[email protected]> * [NSE-650] Scala test ArrowColumnarBatchSerializerSuite is failing (#659) Closes #650 * [NSE-645] Add support to cast bool type to bigint type & string type (#644) * Initial commit * Change arrow branch for test [revert this commit at last] * Revert "Change arrow branch for test [revert this commit at last]" This reverts commit 94ce7fbfc4025d48c252f91701459b4ed091dad9. * use arrow 1.3 branch Signed-off-by: Yuan Zhou <[email protected]> * [NSE-662] Add "like" expression support in WSCG (#663) * Initial commit * Copy headers * Format the code * Change arrow branch for test [will revert at last] * Revert "Change arrow branch for test [will revert at last]" This reverts commit 065547a. * [NSE-126] remove extra headers/namespaces in codegen (#668) * remove extra gandiva header Signed-off-by: Yuan Zhou <[email protected]> * remove extra using namespace Signed-off-by: Yuan Zhou <[email protected]> * [NSE-661] Add trim expression support in WSCG (#664) * Add trim expression support in WSCG * Fix a bug * Format the code Co-authored-by: Wei-Ting Chen <[email protected]> Co-authored-by: Hongze Zhang <[email protected]> Co-authored-by: PHILO-HE <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.