This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-636]Remove log4j1 related unit tests #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified on my env. LGTM! |
|
Thanks Rui.
From: Rui Mo ***@***.***>
Sent: Wednesday, December 22, 2021 9:48 AM
To: oap-project/gazelle_plugin ***@***.***>
Cc: Chen, Weiting ***@***.***>; Author ***@***.***>
Subject: Re: [oap-project/gazelle_plugin] [NSE-636]Remove log4j1 related unit tests (PR #646)
Verified on my env. LGTM!
—
Reply to this email directly, view it on GitHub<#646 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACGRKHKDWFMVWCDONHFMRA3USEU4XANCNFSM5KPTL6DQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
zhouyuan
added a commit
that referenced
this pull request
Dec 30, 2021
* [NSE-636]Remove log4j1 related unit tests (#646) * [NSE-640] Disable compression for tiny payloads in shuffle (#641) Closes #640 * [NSE-653] Add validity checking for get_json_object in WSCG (#654) * Initial commit * Add two unit test cases * Format the code * Update clang format check * [NSE-617] Handle exception in cast expression from string to numeric types in WSCG (#655) * [NSE-660] fix window builder with string (#649) * fix window builder with string Signed-off-by: Yuan Zhou <[email protected]> * fix format Signed-off-by: Yuan Zhou <[email protected]> * [NSE-650] Scala test ArrowColumnarBatchSerializerSuite is failing (#659) Closes #650 * [NSE-645] Add support to cast bool type to bigint type & string type (#644) * Initial commit * Change arrow branch for test [revert this commit at last] * Revert "Change arrow branch for test [revert this commit at last]" This reverts commit 94ce7fbfc4025d48c252f91701459b4ed091dad9. * use arrow 1.3 branch Signed-off-by: Yuan Zhou <[email protected]> * [NSE-662] Add "like" expression support in WSCG (#663) * Initial commit * Copy headers * Format the code * Change arrow branch for test [will revert at last] * Revert "Change arrow branch for test [will revert at last]" This reverts commit 065547a. * [NSE-126] remove extra headers/namespaces in codegen (#668) * remove extra gandiva header Signed-off-by: Yuan Zhou <[email protected]> * remove extra using namespace Signed-off-by: Yuan Zhou <[email protected]> * [NSE-661] Add trim expression support in WSCG (#664) * Add trim expression support in WSCG * Fix a bug * Format the code Co-authored-by: Wei-Ting Chen <[email protected]> Co-authored-by: Hongze Zhang <[email protected]> Co-authored-by: PHILO-HE <[email protected]>
PHILO-HE
added a commit
to PHILO-HE/gazelle_plugin
that referenced
this pull request
Jan 19, 2022
This reverts commit ad4c4e4.
zhouyuan
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Revert "[NSE-636]Remove log4j1 related unit tests (#646)" This reverts commit ad4c4e4. * Revert "[NSE-687]remove exclude log4j when running ut (#688)" This reverts commit 24b5015. * Initial commit * Introduce new version of log4j to arrow * Introduce new log4j version to NSE core * Bump log4j version to 2.17.1 * Revert the changes in unittests.yml to enable Hadoop-2.7.4 test * Add config for log4j 2.x * Ignore failed unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove all directly use log4j unit tests and import log4j cases.
How was this patch tested?
Tested in local server with mvn clean package & mvn test commands