Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ignore to disregard in tainted kmods function #1048

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

Venefilyn
Copy link
Member

@Venefilyn Venefilyn commented Jan 26, 2024

Leftover from #1015

To do:

  • Fix unit tests

Jira Issues: RHELC-

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@Venefilyn Venefilyn added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Jan 26, 2024
@has-bot
Copy link
Member

has-bot commented Jan 26, 2024

/packit test --labels sanity


@oamg/conversions-qe please review results and provide ack.

@Venefilyn
Copy link
Member Author

/packit test --labels sanity

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0309446) 94.35% compared to head (3a093e4) 94.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          47       47           
  Lines        4588     4588           
  Branches      819      819           
=======================================
  Hits         4329     4329           
  Misses        182      182           
  Partials       77       77           
Flag Coverage Δ
centos-linux-7 89.57% <ø> (ø)
centos-linux-8 90.56% <ø> (ø)
centos-linux-9 90.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Venefilyn Venefilyn requested a review from pr-watson January 26, 2024 15:38
@Venefilyn Venefilyn merged commit 3e5acee into main Jan 29, 2024
21 of 59 checks passed
@Venefilyn Venefilyn deleted the fix/ignore-to-disregard branch January 29, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants