[RHELC-1200] Add OVERRIDABLE result to tainted kernel module check #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-watson
added
kind/feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
=======================================
Coverage 94.32% 94.33%
=======================================
Files 47 47
Lines 4549 4557 +8
Branches 810 811 +1
=======================================
+ Hits 4291 4299 +8
Misses 182 182
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Venefilyn
reviewed
Jan 22, 2024
|
/packit test --labels sanity |
r0x0d
reviewed
Jan 22, 2024
r0x0d
reviewed
Jan 22, 2024
Comment on lines
31
to
33
| LINK_KMODS_RH_POLICY = "https://access.redhat.com/third-party-software-support" | ||
| LINK_PREVENT_KMODS_FROM_LOADING = "https://access.redhat.com/solutions/41278" | ||
| LINK_TAINTED_KMOD_DOCS = "https://docs.kernel.org/admin-guide/tainted-kernels.html" |
There was a problem hiding this comment.
Why not access those constants from the tainted_kmods directly?
r0x0d
reviewed
Jan 22, 2024
pr-watson
force-pushed
the
override_tainted_kmods
branch
from
35c3da3 to
a21d8c6
Compare
Co-authored-by: E Gustavsson <[email protected]> Co-authored-by: Rodolfo Olivieri <[email protected]>
for more information, see https://pre-commit.ci
pr-watson
force-pushed
the
override_tainted_kmods
branch
from
8045e3f to
b969566
Compare
|
PR has been tested in a VM |
|
/packit test --labels sanity |
Venefilyn
approved these changes
Jan 25, 2024
9 tasks
Merged
|
The new CONVERT2RHEL_TAINTED_KERNEL_MODULE_CHECK_SKIP is missing at https://github.com/oamg/convert2rhel/wiki/Environment-variables. I'm adding it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an overridable result to the tainted kernel module check allowing users to override in the event of a tainted kernel module detected on the system. Additionally improves the message to the user to not alarm them along with some documentation explaining what a tainted kernel module is.
Jira Issues: RHELC-1200
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant