The git_files picker falls back to find_files when outside of a git repository
#1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekdedic
commented
Oct 13, 2021
Comment on lines
+149
to
+150
| ---@field find_files_fallback boolean: if true, the find_files picker is run instead when the picker is used | ||
| -- outside of a git repository (default: true) |
There was a problem hiding this comment.
Can the docs be split this way?
|
I think we shouldnt do this. No other builtin references another builtin. Doing this here makes it less self contained. The solution presented is less elegant than what users can do in a simple function. |
|
Hi, |
|
I still dont like it. I think it doesnt fit with potential plans of a modular telescope: #1228 |
|
Ok, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally can be disabled with the
find_files_fallbackoption. Continuation of the discussion in #1338.This makes https://github.com/nvim-telescope/telescope.nvim/wiki/Configuration-Recipes#falling-back-to-find_files-if-git_files-cant-find-a-git-directory obsolete