git_files with fallback to find_files when not in git repo picker

[marekdedic]

Is your feature request related to a problem? Please describe.
Hi, I would like to use git_files for most of my work. However, I am not always running vim inside a git repo

Describe the solution you'd like
I'd like to see a picker that behaves like git_files when I'm inside a git repo and like find_files otherwise

[marekdedic]

Basically, what https://github.com/nvim-telescope/telescope.nvim/wiki/Configuration-Recipes#falling-back-to-find_files-if-git_files-cant-find-a-git-directory does in a single picker :)

[fdschmidt93]

I don't see what a dedicated picker would over the recipe apart from technical debt. Maybe telescope build in a fallback option into builtin.git_files but that's a kind of precedent I'd personally want to avoid.

What would a dedicated picker really offer here?

[marekdedic]

Hi, honestly, the reason is just ease-of-use. When I opened the issue, I didn't know about the recipe and Googling didn't show anything either. Only later while looking at what else can telescope do I found the recipe accidentally...

[fdschmidt93]

I agree that customization is something we should further try to improve. However, I'd close this for the time being for tidyness as wontfix as I'm presuming any core member would make a PR for that. Any team member would be free to reopen this though :)

You'd be welcome to make a PR to include this in builtin.git_files here:

telescope.nvim/lua/telescope/builtin/git.lua

Lines 16 to 43 in b5c63c6

	git.files = function(opts)
	local show_untracked = utils.get_default(opts.show_untracked, true)
	local recurse_submodules = utils.get_default(opts.recurse_submodules, false)
	if show_untracked and recurse_submodules then
	error "Git does not support both --others and --recurse-submodules"
	end
	-- By creating the entry maker after the cwd options,
	-- we ensure the maker uses the cwd options when being created.
	opts.entry_maker = opts.entry_maker or make_entry.gen_from_file(opts)
	pickers.new(opts, {
	prompt_title = "Git Files",
	finder = finders.new_oneshot_job(
	vim.tbl_flatten {
	"git",
	"ls-files",
	"--exclude-standard",
	"--cached",
	show_untracked and "--others" or nil,
	recurse_submodules and "--recurse-submodules" or nil,
	},
	opts
	),
	previewer = conf.file_previewer(opts),
	sorter = conf.file_sorter(opts),
	}):find()
	end

Then we can revisit as to whether to include such a fallback. I'd be OK with as I guess it wouldn't increase the maintenance burden.