Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): set allowSyntheticDefaultImports #1827

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

should probably have been included in #1824 🀦
see #1822

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR covers the following errors that would be thrown up by a TS lib-check:

node_modules/pathe/dist/index.d.ts:1:8 - error TS1259: Module '"path"' can only be default-imported using the 'allowSyntheticDefaultImports' flag

1 import path from 'path';
         ~~~~

  node_modules/@types/node/path.d.ts:167:5
    167     export = path;
            ~~~~~~~~~~~~~~
    This module is declared with using 'export =', and can only be used with a default import when using the 'allowSyntheticDefaultImports' flag.

node_modules/rollup-plugin-visualizer/dist/plugin/index.d.ts:2:8 - error TS1259: Module '"/node_modules/open/index"' can only be default-imported using the 'allowSyntheticDefaultImports' flag

2 import opn from "open";
         ~~~

  node_modules/open/index.d.ts:88:1
    88 export = open;
       ~~~~~~~~~~~~~~
    This module is declared with using 'export =', and can only be used with a default import when using the 'allowSyntheticDefaultImports' flag.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working cli labels Nov 10, 2021
@danielroe danielroe requested a review from pi0 November 10, 2021 14:44
@danielroe danielroe self-assigned this Nov 10, 2021
@netlify
Copy link

netlify bot commented Nov 10, 2021

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 8a23257

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/618bdad08a9260000870be06

@pi0 pi0 merged commit 89aa7aa into main Nov 10, 2021
@pi0 pi0 deleted the fix/synthetic-default-imports branch November 10, 2021 16:39
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants