Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): default to skipping lib check #1824

Merged
merged 1 commit into from
Nov 10, 2021
Merged

fix(nuxi): default to skipping lib check #1824

merged 1 commit into from
Nov 10, 2021

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

see #1822

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

some issues will be thrown up by vue-tsc that are somewhat outside our control, such as:

nitro/dist/index.d.ts:14:21 - error TS7016: Could not find a declaration file for module 'fs-extra'. '/node_modules/fs-extra/lib/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/fs-extra` if it exists or add a new declaration (.d.ts) file containing `declare module 'fs-extra';`

import fsExtra from 'fs-extra';
                    ~~~~~~~~~~

listhen/dist/index.d.ts:3:35 - error TS7016: Could not find a declaration file for module 'selfsigned'. '/node_modules/selfsigned/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/selfsigned` if it exists or add a new declaration (.d.ts) file containing `declare module 'selfsigned';`

import { SelfsignedOptions } from 'selfsigned';
                                  ~~~~~~~~~~~~

listhen/dist/index.d.ts:6:16 - error TS2665: Invalid module name in augmentation. Module 'selfsigned' resolves to an untyped module at '/node_modules/selfsigned/index.js', which cannot be augmented.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Nov 10, 2021
@netlify
Copy link

netlify bot commented Nov 10, 2021

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: ad1f979

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/618bc6511238240007b46aa3

@danielroe danielroe added cli enhancement New feature or request labels Nov 10, 2021
@danielroe danielroe requested a review from pi0 November 10, 2021 13:17
@pi0 pi0 merged commit f2d4c65 into main Nov 10, 2021
@pi0 pi0 deleted the fix/skip-lib-check branch November 10, 2021 13:18
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x cli enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants