New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document-driven): throw 404 error when content is missing #1394

Merged

farnabaz merged 3 commits into main from fix/404-page

Aug 2, 2022

Member

farnabaz commented Jul 29, 2022

🔗 Linked issue

resolves nuxt-themes/docus#587

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

I have linked an issue or discussion.
I have updated the documentation accordingly.


          fix(document-driven): throw 404 error when content is missing

f6b6771

netlify bot commented Jul 29, 2022 •

edited

Loading

✅ Deploy Preview for nuxt-content ready!

Name	Link
🔨 Latest commit	`5d90c38`
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt-content/deploys/62e7af3259d0070008f5530e
😎 Deploy Preview	https://deploy-preview-1394--nuxt-content.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

farnabaz marked this pull request as ready for review

July 29, 2022 11:38

Member

atinux commented Jul 29, 2022

Could we check if it sends back the 404 code on SSR as well?

Any chance to add a test case for it?


          test: add test

3e369a2

pi0 reviewed

View reviewed changes

src/runtime/pages/document-driven.vue Outdated Show resolved Hide resolved


          fix: do not use throwError

5d90c38

farnabaz merged commit 343db3e into main

farnabaz deleted the fix/404-page branch

August 2, 2022 13:57

farnabaz mentioned this pull request

Merged

farnabaz added a commit that referenced this pull request


          fix(document-driven): throw 404 error when content is missing (#1394)

519d0fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet