404 page is buggy

[atinux]

See on content docs locally

[Tahul]

@atinux ; how did you browsed to /not-found page?

The 404 page should be /404.

This is an issue for sure, that will be fixed by this commit: 8efa04d

[atinux]

On client-side or directing accessing, it is same result

[Tahul]

I need a second review on this issue!

I think the 404 page works on client-side navigation, but doesn't work with generate and/or direct-hit?

[smarroufin]

I digged into content codebase, but honestly I'm not feeling confident about it, don't even understand a third of this code.

First, even on local server (with yarn dev), a non-existing page does not act as it should. It also gives exactly what Atinux screenshoted.

By placing some logs in content code, I can tell that documentDriven.queryPage('/foo') is called and ends with a failure->catch.
Also documentDriven.surroundQuery('/foo') is called and succeeds with a strange result: [ null, null ] even tho I don't know what this is, it looks suspicious.
At the end of the documentDriven.ts, inside the Promise.all, no _page?.redirect is resolved and I guess we should expect one. Only a _surround is trusy in this scope.
(Btw, /server/api/query does the job right and returns a 404 correctly)

@Tahul Leaving it to Flo or someone qualified on Content.

[atinux]

I guess that is an issue that need to be solved in Nuxt Content on the document driven page injected

Harlan did something that we can maybe be inspired from: https://github.com/harlan-zw/harlanzw.com/blob/main/pages/%5B...slug%5D.vue

Would love your input also @farnabaz

[farnabaz]

I believe we should handle 404 redirect on the document-driven page and let middleware/composable return null in case of 404.

[atinux]

Agree, can you open a PR on nuxt/content @farnabaz ?