Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: color settings #92

Merged
merged 6 commits into from
Feb 24, 2021
Merged

feat: color settings #92

merged 6 commits into from
Feb 24, 2021

Conversation

farnabaz
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

resolves #88

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented Feb 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxtlabs/docus/8jUrTXjPZbeqLb7x3UxY85TyJQ3V
✅ Preview: https://docus-git-tailwind-settings-nuxtlabs.vercel.app

@farnabaz farnabaz marked this pull request as ready for review February 23, 2021 13:31
@farnabaz farnabaz requested a review from atinux February 23, 2021 13:31
@farnabaz
Copy link
Collaborator Author

I changed theme/nuxt.config.js into a plain object.

@farnabaz
Copy link
Collaborator Author

I will update configuration docs and move colors from Nuxt into settings

atinux
atinux reviewed Feb 24, 2021
View reviewed changes
theme/layouts/docs.vue
@@ -31,6 +31,9 @@ export default {
class: [...this.bodyClass]
},
...i18nSeo,
style: [
{ hid: 'docus-theme', cssText: this.$docus.themeStyles, type: 'text/css' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a way to inject it directly from the docus plugin instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed this.

@atinux atinux merged commit 57af79d into main Feb 24, 2021
@atinux atinux deleted the tailwind-settings branch February 24, 2021 22:32
@farnabaz farnabaz mentioned this pull request Feb 25, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Docus Colors to settings.json
2 participants
@farnabaz @atinux