Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move theme style into Docus plugin #101

Merged
merged 4 commits into from
Feb 25, 2021
Merged

fix: move theme style into Docus plugin #101

merged 4 commits into from
Feb 25, 2021

Conversation

farnabaz
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Originally reported in #92 (comment)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented Feb 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxtlabs/docus/3cSSfRJykqE9ABcc7Yh7AxpDX8w2
✅ Preview: https://docus-git-add-theme-style-nuxtlabs.vercel.app

@farnabaz farnabaz requested a review from atinux February 25, 2021 11:31
@atinux
Copy link
Contributor

atinux commented Feb 25, 2021

When navigating on client-side, the colors disapear: https://docus-m1ty2lovu-nuxtlabs.vercel.app/

Also, can we be sure that app.head.style is an array?

@atinux atinux merged commit 615da9c into main Feb 25, 2021
@atinux atinux deleted the add-theme-style branch February 25, 2021 14:43
@atinux atinux removed their request for review February 25, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants