Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lint): Add gocognit to golangci-lint linter list #483

Merged
merged 1 commit into from
Sep 25, 2024
Merged

build(lint): Add gocognit to golangci-lint linter list #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ linters:
- nolintlint
- staticcheck
- unused
- gocognit
linters-settings:
nolintlint:
require-explanation: true
Expand Down
5 changes: 3 additions & 2 deletions controllers/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,10 @@
ciValue := ci.Value
if gck, ok := groupCategoriesByKey[ciKey]; ok {
groupCategoriesByKey[ciKey] = append(gck, ciValue)
} else {
groupCategoriesByKey[ciKey] = []string{ciValue}
continue

Check warning on line 472 in controllers/helpers.go

View check run for this annotation

Codecov / codecov/patch

controllers/helpers.go#L472 

Added line #L472 was not covered by tests
}

groupCategoriesByKey[ciKey] = []string{ciValue}

Check warning on line 475 in controllers/helpers.go

View check run for this annotation

Codecov / codecov/patch

controllers/helpers.go#L475 

Added line #L475 was not covered by tests
thunderboltsid marked this conversation as resolved.
Show resolved Hide resolved
}

for key, values := range groupCategoriesByKey {
Expand Down
Loading