Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lint): Add gocognit to golangci-lint linter list #483

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

thunderboltsid
Copy link
Contributor

gocognit aims to reduce "cognitive complexity" of functions.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.00%. Comparing base (d967a56) to head (783f8ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
controllers/helpers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   33.00%   33.00%           
=======================================
  Files          17       17           
  Lines        1809     1809           
=======================================
  Hits          597      597           
  Misses       1192     1192           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Code looks cleaner than before

gocognit aims to reduce "cognitive complexity" of functions.
@thunderboltsid thunderboltsid merged commit 78f61d1 into main Sep 25, 2024
8 of 11 checks passed
@thunderboltsid thunderboltsid deleted the issue/enable-gocognit branch September 25, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants