Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PR #438 to release-v1.3 #440

Merged
merged 1 commit into from
May 31, 2024

Conversation

thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented May 30, 2024

Cherry-Pick Details

Note: The cherry-pick excludes the clusterclass flavor move test in the original PR as clusterclass support does not exist in release-v1.3

Also set ownerReference on trust bundle configmaps so CMs get moved
when clusterctl move happens.
@thunderboltsid thunderboltsid force-pushed the issue/cherry-pick-move-1.3 branch from ccc4c4f to 3bfc65a Compare May 30, 2024 17:04
Copy link

✅ None of your dependencies violate policy!

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 17.84%. Comparing base (bd2ccba) to head (3bfc65a).

Files Patch % Lines
controllers/nutanixcluster_controller.go 87.50% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-v1.3     #440      +/-   ##
================================================
+ Coverage         16.90%   17.84%   +0.94%     
================================================
  Files                22       22              
  Lines              2118     2146      +28     
================================================
+ Hits                358      383      +25     
- Misses             1760     1763       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid thunderboltsid added the bug Something isn't working label May 30, 2024
Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit b81cb37 into release-v1.3 May 31, 2024
12 of 13 checks passed
@thunderboltsid thunderboltsid deleted the issue/cherry-pick-move-1.3 branch May 31, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants