Set OwnerRef on TrustBundle configmaps and add selfhosted E2E test #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
force-pushed
the
jira/krbn-8210
branch
from
ab4005c to
2af8c4f
Compare
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
+ Coverage 28.37% 29.65% +1.28%
==========================================
Files 14 14
Lines 1304 1332 +28
==========================================
+ Hits 370 395 +25
- Misses 934 937 +3 ☔ View full report in Codecov by Sentry. |
thunderboltsid
commented
May 29, 2024
thunderboltsid
force-pushed
the
jira/krbn-8210
branch
2 times, most recently
from
773cbaf to
9e3a2fb
Compare
thunderboltsid
changed the title
thunderboltsid
changed the title
thunderboltsid
changed the title
|
/retest |
thunderboltsid
force-pushed
the
jira/krbn-8210
branch
from
9e3a2fb to
3e89af5
Compare
|
/retest |
thunderboltsid
force-pushed
the
jira/krbn-8210
branch
3 times, most recently
from
1302d8d to
85b3f8d
Compare
|
/retest |
deepakm-ntnx
approved these changes
May 29, 2024
thunderboltsid
force-pushed
the
jira/krbn-8210
branch
from
85b3f8d to
abcb42a
Compare
Also set ownerReference on trust bundle configmaps so CMs get moved when clusterctl move happens.
thunderboltsid
force-pushed
the
jira/krbn-8210
branch
from
abcb42a to
0100072
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thunderboltsid
added a commit
that referenced
this pull request
May 30, 2024
Also set ownerReference on trust bundle configmaps so CMs get moved when clusterctl move happens.
thunderboltsid
added a commit
that referenced
this pull request
May 30, 2024
Also set ownerReference on trust bundle configmaps so CMs get moved when clusterctl move happens.
thunderboltsid
added a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a E2E test for clusterctl move and also adds a method to reconcile trust bundle refs in NutanixmachineReconciler to set ownerReference on trust bundle configmaps so those configmaps get moved when clusterctl move operation happens.