Fix OPF prediction models #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyolight
approved these changes
Jun 5, 2017
src/nupic/regions/record_sensor.py
Outdated
| description="The field to be predicted. This will result in the " | ||
| "outputs actValueOut and bucketIdxOut not being " | ||
| "populated.", | ||
| dataType="Byte", |
There was a problem hiding this comment.
The dataType is confusing because it's a string. Should the description say "The field name to be predicted..."?
|
@rhyolight - Added a major commit that removes the CLAClassifier and derivatives. Tests for CLAClassifier are removed but other usages are replaced with the SDRClassifier. |
|
Great, assuming you get tests passing, LTGM. |
|
I'm going to wait until #3669 is merged, revalidate this PR, and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes "predictedFieldIdx" to just "predictedField" so network clients don't have to try to figure out the index of the predicted field (which may vary based on the dataSource in the encoder). Additionally, missing links for the HTMPredictionModel classifier are added to fix broken prediction capability.
@ywcui1990 - fyi, not sure if this conflicts with your changes
fixes NUP-2448