Fix SDR classifier Region #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyolight
reviewed
Jun 6, 2017
| # ensures that recordNum increases monotonically | ||
| if len(self._patternNZHistory) > 0: | ||
| if recordNum < self._patternNZHistory[-1][0]: | ||
| raise ValueError("the record number has to increase monotonically") |
There was a problem hiding this comment.
Add to the docstring:
:raises: (ValueError) when record number does not increase monotonically.
scottpurdy
approved these changes
Jun 6, 2017
|
@ywcui1990 - are you ready to merge this? I want to revalidate #3665 once this is merged to make sure the two changes are compatible. |
|
@scottpurdy I am ready to merge this. I will push a separate PR in nupic.core. I expect this PR to break regression tests since it affects classification/prediction accuracy. Do you know why the regression tests pass with this PR? |
|
I believe the regression tests only run on a nightly for master, not PRs. @rhyolight - is that right? |
|
@scottpurdy Yes, it's nightly on master only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3651
Summary
@scottpurdy This is a fix for the broken SDR classifier. If this looks good to you, I will make the same change in nupic.core