Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octokit v9.0 introduced 'Artifact' into global namespace #1317

Closed
amis92 opened this issue Jan 25, 2024 · 1 comment · Fixed by #1318
Closed

Octokit v9.0 introduced 'Artifact' into global namespace #1317

amis92 opened this issue Jan 25, 2024 · 1 comment · Fixed by #1318
Labels

Comments

@amis92
Copy link
Contributor

amis92 commented Jan 25, 2024

Usage Information

NUKE v8.0

Description

Octokit dependency update to v9 in NUKE v8 has introduced an Artifact type into global namespace, which collides with any self-declared type like that and requires workarounds like extern alias.

There's been a bugfix and Octokit v9.1.1 with it is available. See octokit/octokit.net#2861

Reproduction Steps

namespace N1 {
    public class Artifact { }
}
namespace N2 {
    using Artifact = N1.Artifact; // error
    public class C : Artifact { }
}

Expected Behavior

The above causes no issue and also compiles without using Artifact = ....

Actual Behavior

An error about Artifact in global-namespace is raised.

Regression?

Yes, worked fine in NUKE v7.0.6 as it referenced Octokit v5 which had no such issues.

Known Workarounds

Reference Octokit directly with <PackageReference Include="Octokit" Aliases="OctokitNs" />

Could you help with a pull-request?

No

@amis92 amis92 added the bug label Jan 25, 2024
amis92 added a commit to amis92/nuke that referenced this issue Jan 25, 2024
@matkoch matkoch closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
@amis92
Copy link
Contributor Author

amis92 commented Jan 26, 2024

@matkoch can you possibly shed a bit more light as to the closing of this issue? It's a transient dependency that NUKE pulls in and prevents people from using their own Artifact type in their scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants