-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: class Artifact is in global namespace #2861
Comments
It seems in general all models have the @nickfloyd you've approved that PR from @thomhurst any chance for a fix? |
Apologies. Must've had some weird IDE settings on that didn't want to add namespaces. |
oof great catch y'all... Thank you @thomhurst for the follow up here - I'll get reviewed and out the door shortly |
The fix has been released. Again, apologies for the trouble and thanks @thomhurst for the super quick fix. |
Thanks so much! |
What happened?
I am using Nuke.
I have my custom code to define Build and have defined the Artifact class in my custom code.
After updating Nuke to the new version 8.0.0 which depends on >= 9.0.0, the Artifact class from Octokit wins with my custom class which breaks usages of my library and I can't fix this without breaking change.
This is because Artifact from Octokit is in the global namespace.
Is there any chance that this type could be moved to some namespace? :)
Versions
9.0.0 for sure.
Relevant log output
Code of Conduct
The text was updated successfully, but these errors were encountered: