Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: class Artifact is in global namespace #2861

Closed
1 task done
darthkurak opened this issue Jan 25, 2024 · 5 comments · Fixed by #2862
Closed
1 task done

[BUG]: class Artifact is in global namespace #2861

darthkurak opened this issue Jan 25, 2024 · 5 comments · Fixed by #2862
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@darthkurak
Copy link

What happened?

I am using Nuke.
I have my custom code to define Build and have defined the Artifact class in my custom code.
After updating Nuke to the new version 8.0.0 which depends on >= 9.0.0, the Artifact class from Octokit wins with my custom class which breaks usages of my library and I can't fix this without breaking change.
This is because Artifact from Octokit is in the global namespace.

Is there any chance that this type could be moved to some namespace? :)

Versions

9.0.0 for sure.

Relevant log output

Namespace '<global namespace>' contains a definition conflicting with alias 'Artifact'

Code of Conduct

  • I agree to follow this project's Code of Conduct
@darthkurak darthkurak added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jan 25, 2024
@amis92
Copy link

amis92 commented Jan 25, 2024

It seems in general all models have the namespace Octokit, except those added in #2782 (see diff)

@nickfloyd you've approved that PR from @thomhurst any chance for a fix?

@thomhurst
Copy link
Contributor

Apologies. Must've had some weird IDE settings on that didn't want to add namespaces.
Have added namespaces in #2862.

@nickfloyd
Copy link
Contributor

oof great catch y'all... Thank you @thomhurst for the follow up here - I'll get reviewed and out the door shortly

@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Jan 25, 2024
@nickfloyd
Copy link
Contributor

The fix has been released. Again, apologies for the trouble and thanks @thomhurst for the super quick fix.

@amis92
Copy link

amis92 commented Jan 25, 2024

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants