Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nucliadb_performance #2875

Merged
merged 1 commit into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
- name: Lint source code
run: |
source .venv/bin/activate
for package in nucliadb nucliadb_utils nucliadb_telemetry nucliadb_sdk nucliadb_dataset nucliadb_models nucliadb_performance
for package in nucliadb nucliadb_utils nucliadb_telemetry nucliadb_sdk nucliadb_dataset nucliadb_models
do
make -C $package lint || ERROR=1
done
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
- name: Lint source code
run: |
source .venv/bin/activate
for package in nucliadb nucliadb_utils nucliadb_telemetry nucliadb_sdk nucliadb_dataset nucliadb_models nucliadb_performance
for package in nucliadb nucliadb_utils nucliadb_telemetry nucliadb_sdk nucliadb_dataset nucliadb_models
do
make -C $package lint || ERROR=1
done
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ tmp/nucliadb
data
logs

# KB exports used in performance tests
nucliadb_performance/exports

**/tikv-server
**/pd-server
**/nats-server
Expand Down
1 change: 0 additions & 1 deletion .licenserc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ header:
- "nucliadb_dataset/**"
- "nucliadb_node/**"
- "nucliadb_paragraphs[0-9]*/**"
- "nucliadb_performance/**"
- "nucliadb_protos/build.rs"
- "nucliadb_protos/src/lib.rs"
- "nucliadb_relations[0-9]*/**"
Expand Down
8 changes: 0 additions & 8 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ repos:
types: ["python"]
pass_filenames: false

- id: lint_nucliadb_performance
name: Lint nucliadb_performance
entry: make -C nucliadb_performance lint
language: system
files: (^nucliadb_performance/)
types: ["python"]
pass_filenames: false

- id: lint_nucliadb_sdk
name: Lint nucliadb_sdk
entry: make -C nucliadb_sdk lint
Expand Down
1 change: 0 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ COPY nucliadb_telemetry /usr/src/app/nucliadb_telemetry
COPY nucliadb_protos /usr/src/app/nucliadb_protos
COPY nucliadb_models /usr/src/app/nucliadb_models
COPY nucliadb /usr/src/app/nucliadb
COPY nucliadb_performance /usr/src/app/nucliadb_performance
COPY nidx/nidx_protos /usr/src/app/nidx/nidx_protos

# Create a fake binding to avoid installing the real one
Expand Down
1 change: 0 additions & 1 deletion Dockerfile.withbinding
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ COPY nucliadb_telemetry /usr/src/app/nucliadb_telemetry
COPY nucliadb_protos /usr/src/app/nucliadb_protos
COPY nucliadb_models /usr/src/app/nucliadb_models
COPY nucliadb /usr/src/app/nucliadb
COPY nucliadb_performance /usr/src/app/nucliadb_performance
COPY nidx /usr/src/app/nidx

# Install our packages to the virtualenv
Expand Down
2 changes: 0 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ python-code-lint:
make -C nucliadb_utils/ format
make -C nucliadb/ format
make -C nucliadb_telemetry/ format
make -C nucliadb_performance/ format

make -C nucliadb/ lint
make -C nucliadb_utils/ lint
Expand All @@ -58,7 +57,6 @@ python-code-lint:
make -C nucliadb_dataset/ lint
make -C nucliadb_models/ lint
make -C nucliadb_sidecar/ lint
make -C nucliadb_performance/ lint


rust-code-lint: fmt-all
Expand Down
3 changes: 0 additions & 3 deletions mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ disable_error_code = var-annotated, has-type, attr-defined, misc, union-attr
[mypy-molotov.*]
ignore_missing_imports = True

[mypy-nucliadb_performance.*]
ignore_missing_imports = True

[mypy-nucliadb_protos.*]
; These are required because we have duplicated message names in different protos
; that eventually get imported into a single proto. The code actually works because
Expand Down
100 changes: 0 additions & 100 deletions nucliadb_performance/Makefile

This file was deleted.

32 changes: 0 additions & 32 deletions nucliadb_performance/README.md

This file was deleted.

18 changes: 0 additions & 18 deletions nucliadb_performance/nucliadb_performance/__init__.py

This file was deleted.

18 changes: 0 additions & 18 deletions nucliadb_performance/nucliadb_performance/hosted/__init__.py

This file was deleted.

This file was deleted.

Loading
Loading