Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nucliadb_performance #2875

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Remove nucliadb_performance #2875

merged 1 commit into from
Feb 13, 2025

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Feb 13, 2025

Description

It's not used, so better not have to maintain it

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (04d4073) to head (85eba5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2875      +/-   ##
==========================================
- Coverage   84.08%   84.04%   -0.05%     
==========================================
  Files         471      471              
  Lines       34794    34794              
  Branches    10602    10602              
==========================================
- Hits        29256    29242      -14     
- Misses       4988     5001      +13     
- Partials      550      551       +1     
Flag Coverage Δ
nidx 77.63% <ø> (ø)
nucliadb 75.40% <ø> (-0.09%) ⬇️
nucliadb-ingest 40.95% <ø> (ø)
nucliadb-reader 42.69% <ø> (ø)
nucliadb-search 44.33% <ø> (ø)
nucliadb-standalone 47.32% <ø> (ø)
nucliadb-train 45.48% <ø> (ø)
nucliadb-writer 46.85% <ø> (ø)
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 84.82% <ø> (ø)
nucliadb_sdk 89.67% <ø> (ø)
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran requested a review from a team February 13, 2025 15:38
@lferran lferran merged commit 1ca529c into main Feb 13, 2025
43 checks passed
@lferran lferran deleted the delete-ndb-performance branch February 13, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants