nsqadmin: connections count fixes #1134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total connections count on the Topic page was accidentally broken recently in #1118.
I'm not sure when the rate column in the Totals row of the Channel page started having an issue, the code has been that way since 2015 ...
I also had some problems with gulp:
with nodejs 10.x:
first attempt with nodejs 8.x:
just doing a "gulp clean" on its own seemed to resolve all my issues after that.
cc @mreiferson @jehiah