nsqadmin: more robust gulp instructions

seems our versions of npm packages does not work with nodejs 10.x gulp clean and build in parallel does not always work
nsqio · Feb 8, 2019 · 11fbb2f · 11fbb2f
1 parent 0148775
commit 11fbb2f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/nsqadmin/README.md b/nsqadmin/README.md
@@ -7,8 +7,9 @@ Read the [docs](http://nsq.io/components/nsqadmin.html)
 
 ## Working Locally
 
+ 0. install nodejs 8.x (includes npm)
  1. `$ npm install`
- 2. `$ ./gulp clean watch` or `$ ./gulp clean build`
+ 2. `$ gulp --series clean watch` or `$ ./gulp --series clean build`
  3. `$ go-bindata --debug --pkg=nsqadmin --prefix=static/build static/build/...`
  4. `$ go build && ./nsqadmin`
  5. make changes (repeat step 5 if you make changes to any Go code)

diff --git a/nsqadmin/gulp b/nsqadmin/gulp
@@ -1,2 +1,2 @@
-#!/bin/bash
-exec ./node_modules/.bin/gulp $@
+#!/bin/sh
+exec ./node_modules/.bin/gulp "$@"