Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): init, app, component and lib generators #19130

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 12, 2023

Same as #19018

  • Added init generator
  • Added app generator
  • Added lib generator
  • Added component generator
  • Created vue plugin overview page in docs (under nx.dev/packages/vue)
  • Added e2e targets
  • nx/vue e2e tests
  • Vue preset in create-nx-workspace
    Screenshot 2023-09-13 at 10 29 31 AM

@jaysoo jaysoo requested review from a team, FrozenPandaz and vsavkin as code owners September 12, 2023 17:35
@jaysoo jaysoo requested a review from mandarini September 12, 2023 17:35
@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 4:28pm

@jaysoo jaysoo marked this pull request as draft September 12, 2023 17:35
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have instinctively expected to see a .vue file override within ESLint configs to only apply vue-specific lint rules to vue files, but that doesn't seem to be the case here?

@mandarini
Copy link
Member

mandarini commented Sep 13, 2023

@JamesHenry this is from the docs on how to configure the plugin: https://eslint.vuejs.org/user-guide/

Edit: sorry, providing more details

npm create vue@latest generates this:

/* eslint-env node */
require('@rushstack/eslint-patch/modern-module-resolution')

module.exports = {
  root: true,
  'extends': [
    'plugin:vue/vue3-essential',
    'eslint:recommended',
    '@vue/eslint-config-typescript'
  ],
  parserOptions: {
    ecmaVersion: 'latest'
  }
}

so I think that the vue-related plugins should be taking care of things.

@JamesHenry
Copy link
Collaborator

@mandarini @jaysoo and I discussed my linting concerns and they are going to make a few tweaks

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from a linting perspective now 👍

@FrozenPandaz FrozenPandaz merged commit 769974b into nrwl:master Sep 13, 2023
@jaysoo jaysoo deleted the feat/vue-lib-gen branch September 13, 2023 19:07
jaysoo added a commit to jaysoo/nx that referenced this pull request Sep 13, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants