Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vue): init, app, component and lib generators #19018

Closed
wants to merge 1 commit into from
Closed

feat(vue): init, app, component and lib generators #19018

wants to merge 1 commit into from

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Sep 6, 2023 •
edited
Loading

  • Added init generator
  • Added app generator
  • Added lib generator
  • Added component generator
  • Created vue plugin overview page in docs (under nx.dev/packages/vue)

@jaysoo

TODO:

  • Adjust vite generator to accept vue as uiFramework
  • See if there's anything extra needed for the target generation (if vite accepts vue as framework)
  • component generator
  • refine available options
  • make sure all works as expected
  • correctly configure tests
  • Correctly configure styles

@mandarini mandarini self-assigned this Sep 6, 2023
@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 3:08pm

@nx-cloud
Copy link

nx-cloud bot commented Sep 6, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0093ca8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx affected --target=e2e --base=50b62524f592f094c6ce011a497edfcb4ea3d422 --head=0093ca85061345fcf3a3b66efa2841e7284512c3 --parallel=1
✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

jaysoo
jaysoo reviewed Sep 6, 2023
View reviewed changes
packages/vue/generators.json Outdated Show resolved Hide resolved
jaysoo
jaysoo reviewed Sep 6, 2023
View reviewed changes
packages/vue/generators.json Outdated Show resolved Hide resolved
@mandarini mandarini force-pushed the feat/vue-lib-gen branch 2 times, most recently from c481bd6 to 3204e3e Compare September 6, 2023 14:28
@mandarini mandarini force-pushed the feat/vue-lib-gen branch 4 times, most recently from 4295bc2 to ca05078 Compare September 6, 2023 14:55
@mandarini mandarini force-pushed the feat/vue-lib-gen branch 2 times, most recently from a6435e7 to c3d036d Compare September 6, 2023 15:11
@mandarini mandarini requested a review from jaysoo September 6, 2023 15:12
@mandarini mandarini marked this pull request as ready for review September 6, 2023 15:12
@mandarini mandarini force-pushed the feat/vue-lib-gen branch 3 times, most recently from 3d22537 to 1a7f57c Compare September 11, 2023 17:26
@mandarini mandarini changed the title feat(vue): init, component and lib generators feat(vue): init, app, component and lib generators Sep 11, 2023
@mandarini mandarini force-pushed the feat/vue-lib-gen branch 4 times, most recently from 084afc1 to 2d1c990 Compare September 12, 2023 07:18
@mandarini mandarini mentioned this pull request Sep 12, 2023
Closed
@mandarini mandarini force-pushed the feat/vue-lib-gen branch 2 times, most recently from 4e52418 to a17327b Compare September 12, 2023 12:59
FrozenPandaz
FrozenPandaz requested changes Sep 12, 2023
View reviewed changes
e2e/vue/src/vue.test.ts Outdated Show resolved Hide resolved
e2e/vue/src/vue.test.ts Outdated Show resolved Hide resolved
packages/js/src/index.ts Outdated Show resolved Hide resolved
packages/vue/src/generators/application/lib/normalize-options.ts Outdated Show resolved Hide resolved
packages/js/src/utils/find-free-port.ts Outdated Show resolved Hide resolved
packages/vue/src/utils/create-ts-config.ts Outdated Show resolved Hide resolved
packages/vue/src/utils/create-ts-config.ts Outdated Show resolved Hide resolved
packages/vue/src/utils/editViteConfig.ts Outdated Show resolved Hide resolved
packages/vue/src/utils/versions.ts Outdated Show resolved Hide resolved
packages/vue/src/utils/versions.ts Outdated Show resolved Hide resolved
@mandarini mandarini mentioned this pull request Sep 12, 2023
Closed
@jaysoo jaysoo mentioned this pull request Sep 12, 2023
Merged
@jaysoo
Copy link
Member

jaysoo commented Sep 12, 2023

Couldn't push an update to this branch. Opened a draft here with some fixes and cleanup. #19130

Feel free to reset to that ref and push here.

@mandarini
Copy link
Member Author

Closing in favor of #19130

@mandarini mandarini closed this Sep 13, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

@isaacplmann isaacplmann isaacplmann approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz is a code owner

Assignees

@mandarini mandarini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mandarini @jaysoo @isaacplmann @FrozenPandaz