Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ngrx-feature-store should respect paths in names #18905 #18913

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 30, 2023

Current Behavior

Using a path as a name for the ngrx-feature-store generator produces incorrect results

Expected Behavior

Using a path should produce correct results for imports and names of tokens

Related Issue(s)

Fixes #18905

@Coly010 Coly010 requested a review from a team as a code owner August 30, 2023 15:11
@Coly010 Coly010 requested a review from leosvelperez August 30, 2023 15:11
@Coly010 Coly010 self-assigned this Aug 30, 2023
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 3:12pm

@Coly010 Coly010 merged commit 818d04c into nrwl:master Aug 31, 2023
@Coly010 Coly010 deleted the angular/fix-feature-store-name branch August 31, 2023 11:02
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants