Feature store generator generates incorrect imports and appends directory name to tokens if --name contains directories

[hgschwibbe]

Current Behavior

The following command generates imports that does not exist:

nx g @nx/angular:ngrx-feature-store --name supply-chain/supply-chain --facade true

The feature state was successfully generated in a subdirectory below of the +state directory like previous nx versions did before
(src/app/+state/supply-chain). Now the files below the subdirectory imports from './supply-chain/supply-chain.*' instead of from './supply-chain.*'.

For Example:

import { createAction, props } from '@ngrx/store';
import { SupplyChainSupplyChainEntity } from './supply-chain/supply-chain.models';

export const initSupplyChainSupplyChain = createAction(
  '[SupplyChainSupplyChain Page] Init'
);

export const loadSupplyChainSupplyChainSuccess = createAction(
  '[SupplyChainSupplyChain/API] Load SupplyChainSupplyChain Success',
  props<{ supplyChainSupplyChain: SupplyChainSupplyChainEntity[] }>()
);

export const loadSupplyChainSupplyChainFailure = createAction(
  '[SupplyChainSupplyChain/API] Load SupplyChainSupplyChain Failure',
  props<{ error: any }>()
);

Also the entity name generation took the directory into account:
It generates the entity name SupplyChainSupplyChainEntity instead of SupplyChainEntity.

A workaround might be generating with the --directory parameter, but this overrides the +state root directory. So you have always to prefix it with +state which leads to typing errors:
nx g @nx/angular:ngrx-feature-store --directory +state/supply-chain --name supply-chain --facade true

Its up to you how to fix it:

• be compatible with the old approach and take paths into account while using the --name parameter
• or provide an additional --subdirectory parameter that does not override/break the default +state root directory.

Expected Behavior

Imports could be resolved.
Generated code does not prefix everything with the directory names.

Steps to Reproduce

1. nx g @nx/angular:ngrx-feature-store --name supply-chain/supply-chain --facade true

Nx Report

Node   : 18.17.1
   OS     : linux-x64
   npm    : 9.6.7

   nx (global)        : 16.7.2
   nx                 : 16.7.4
   @nx/js             : 16.7.4
   @nx/jest           : 16.7.4
   @nx/linter         : 16.7.4
   @nx/workspace      : 16.7.4
   @nx/angular        : 16.7.4
   @nx/cypress        : 16.7.4
   @nx/devkit         : 16.7.4
   @nx/eslint-plugin  : 16.7.4
   @nrwl/tao          : 16.7.4
   @nx/webpack        : 16.7.4
   typescript         : 5.1.6
   ---------------------------------------
   Community plugins:
   @ngrx/component-store : 16.0.1
   @ngrx/effects         : 16.0.1
   @ngrx/entity          : 16.0.1
   @ngrx/router-store    : 16.0.1
   @ngrx/schematics      : 16.0.1
   @ngrx/store           : 16.0.1
   @ngrx/store-devtools  : 16.0.1

Failure Logs

No response

Package Manager Version

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.