Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): nx plugin submission nx-gcp-cache #18172

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

davidgarciab
Copy link
Contributor

Community Plugin Submission

nx-gcp-cache

nx-gcp-cache plugin provides a distributed remote cache using Google Cloud Storage.

It solves the problem of having a distributed remote cache using a self-hosted solution instead of Nx Cloud.

The plugin provides a generator to update the nx.json file and changes the default runner to use the plugin, prompting the user to provide the bucket name.

@davidgarciab davidgarciab requested a review from a team as a code owner July 18, 2023 23:06
@davidgarciab davidgarciab requested a review from AgentEnder July 18, 2023 23:06
@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:31pm

@isaacplmann isaacplmann requested a review from a team as a code owner September 7, 2023 14:26
@isaacplmann isaacplmann requested a review from vsavkin September 7, 2023 14:26
@isaacplmann
Copy link
Collaborator

isaacplmann commented Sep 7, 2023

The plugin looks good, except you need to have some form of e2e tests running in CI. Once that is in place, leave a comment on this PR and I'll get it merged.

Sorry for the delayed response, we've changed some of our processes so that plugin submissions shouldn't wait this long without a response again.

@davidgarciab
Copy link
Contributor Author

@isaacplmann I have added E2E test and it's running in CI.
You can check it here

Let me know if you need anything else to include the plugin.
Thanks!

@isaacplmann isaacplmann merged commit 9f0e9c8 into nrwl:master Sep 22, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants