Merge branch 'master' into master

.circleci/config.yml

@@ -61,6 +61,7 @@ commands:
           name: Install Dependencies
           command: |
             pnpm install --frozen-lockfile
+            pnpm playwright install --with-deps firefox webkit chrome
       - save_cache:
           name: Save pnpm Package Cache
           key: node-deps-{{ arch }}-v3-{{ checksum "pnpm-lock.yaml" }}
@@ -132,7 +133,7 @@ jobs:
       GIT_COMMITTER_NAME: Test
       NX_E2E_CI_CACHE_KEY: e2e-circleci-<< parameters.os >>
       SELECTED_PM: << parameters.pm >>
-      NX_E2E_RUN_CYPRESS: 'true'
+      NX_E2E_RUN_E2E: 'true'
       NX_VERBOSE_LOGGING: 'false'
       NX_NATIVE_LOGGING: 'false'
       NX_PERF_LOGGING: 'false'
@@ -145,7 +146,7 @@ jobs:
       - run:
           name: Set dynamic nx run variable
           command: |
-            echo "export NX_RUN_GROUP=\"run-group-<< parameters.os >>-$CIRCLE_WORKFLOW_ID\";" >> $BASH_ENV
+            echo "export NX_CI_EXECUTION_ENV=\"<< parameters.os >>\";" >> $BASH_ENV
       - setup:
           os: << parameters.os >>
       - run:
@@ -168,7 +169,7 @@ jobs:
       - run:
           name: Set dynamic nx run variable
           command: |
-            echo "export NX_RUN_GROUP=\"run-group-linux-$CIRCLE_WORKFLOW_ID\";" >> $BASH_ENV
+            echo "export NX_CI_EXECUTION_ENV=\"linux\";" >> $BASH_ENV
       - setup:
           os: linux
       - nx/set-shas:
@@ -187,7 +188,7 @@ jobs:
             pnpm nx-cloud record -- nx format:check --base=$NX_BASE --head=$NX_HEAD &
             pids+=($!)
 
-            pnpm nx run-many -t check-imports check-commit check-lock-files depcheck check-codeowners documentation --parallel=1 --no-dte &
+            pnpm nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte &
             pids+=($!)
 
             pnpm nx affected --target=lint --base=$NX_BASE --head=$NX_HEAD --parallel=3 &
@@ -208,14 +209,13 @@ jobs:
     executor: macos
     environment:
       NX_E2E_CI_CACHE_KEY: e2e-circleci-macos
-      NX_DAEMON: 'true'
       NX_PERF_LOGGING: 'false'
       SELECTED_PM: 'npm' # explicitly define npm for macOS tests
     steps:
       - run:
           name: Set dynamic nx run variable
           command: |
-            echo "export NX_RUN_GROUP=\"run-group-macos-$CIRCLE_WORKFLOW_ID\";" >> $BASH_ENV
+            echo "export NX_CI_EXECUTION_ENV=\"macos\";" >> $BASH_ENV
       - setup:
           os: macos
       - rust/install

.eslintrc.json

@@ -47,6 +47,7 @@
           "error",
           {
             "enforceBuildableLibDependency": true,
+            "checkDynamicDependenciesExceptions": [".*"],
             "allow": [],
             "depConstraints": [
               {

.github/ISSUE_TEMPLATE/1-bug.yml

@@ -1,6 +1,6 @@
 name: 🐞 Bug Report
 description: This form is to report unexpected behavior in Nx.
-labels: [ "type: bug" ]
+labels: ["type: bug"]
 body:
   - type: markdown
     attributes:
@@ -53,6 +53,13 @@ body:
       label: Failure Logs
       description: Please include any relevant log snippets or files here. This will be automatically formatted into code, so no need for backticks.
       render: shell
+  - type: input
+    id: pm
+    attributes:
+      label: Package Manager Version
+      description: |
+        If `nx report` doesn't work, please provide the name and the version of your package manager.
+        You can get version information by running `yarn --version`, `pnpm --version` or `npm --version`, depending on the package manager used.
   - type: checkboxes
     id: os
     attributes:

.github/PULL_REQUEST_TEMPLATE/COMMUNITY_PLUGIN.MD

@@ -5,6 +5,27 @@ _[Please make sure you have read the submission guidelines before posting an PR]
 
 Thanks for submitting your Nx Plugin to our community plugins list. Make sure to follow these steps to ensure that your PR is approved in a timely manner.
 
+## Plugin Requirements
+
+Before you submit your plugin to be listed in our registry, it needs to meet the following requirements:
+- Run some kind of automated e2e tests in your repository
+- Include `@nx/devkit` as a `dependency` in the plugin's `package.json`
+- List a `repository.url` in the plugin's `package.json`
+
+i.e.
+
+```
+{
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/nrwl/nx.git",
+    "directory": "packages/web"
+  }
+}
+```
+
+Note: We reserve the right to remove unmaintained plugins from the registry.  If the plugins become maintained again, they can be resubmitted to the registry.
+
 ## Steps to Submit Your Plugin
 - Use the following commit message template: `chore(core): nx plugin submission [PLUGIN_NAME]`
 - Update the `community/approved-plugins.json` file with a new entry for your plugin that includes `name`, `url`, `description`:
@@ -21,7 +42,7 @@ Example:
 }]
 ```
 
-Once merged, your will plugin will be available when running the `nx list` command, and will also be available in the Plugin browser on [nx.dev](https://nx.dev)
+Once merged, your plugin will be available when running the `nx list` command, and will also be available in the Plugin Registry on [nx.dev](https://nx.dev/extending-nx/registry)
 -->
 
 # Community Plugin Submission

.github/workflows/e2e-matrix.yml

@@ -414,8 +414,8 @@ jobs:
           npm_config_registry: http://localhost:4872
           YARN_REGISTRY: http://localhost:4872
           NX_CACHE_DIRECTORY: 'tmp'
-          NX_E2E_SKIP_BUILD_CLEANUP: 'true'
-          NX_E2E_RUN_CYPRESS: 'true'
+          NX_E2E_SKIP_CLEANUP: 'true'
+          NX_E2E_RUN_E2E: 'true'
           NX_E2E_VERBOSE_LOGGING: 'true'
           NX_PERF_LOGGING: 'false'
           NX_DAEMON: 'true'

.github/workflows/e2e-windows.yml

@@ -302,8 +302,8 @@ jobs:
           SELECTED_PM: ${{ matrix.package_manager }}
           npm_config_registry: http://localhost:4872
           NX_CACHE_DIRECTORY: 'tmp'
-          NX_E2E_SKIP_BUILD_CLEANUP: 'true'
-          NX_E2E_RUN_CYPRESS: 'true'
+          NX_E2E_SKIP_CLEANUP: 'true'
+          NX_E2E_RUN_E2E: 'true'
           NX_E2E_VERBOSE_LOGGING: 'true'
           NX_PERF_LOGGING: 'false'
           NX_DAEMON: 'true'

.github/workflows/generate-embeddings.yml

@@ -0,0 +1,53 @@
+name: Generate embeddings
+
+on:
+  schedule:
+    - cron: "0 5 * * 0,4" # sunday, thursday 5AM
+  workflow_dispatch:
+jobs:
+  cache-and-install:
+    if: github.repository == 'nrwl/nx'
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [18]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Install Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: 18
+
+      - name: Install pnpm
+        uses: pnpm/action-setup@v2
+        id: pnpm-install
+        with:
+          version: 7
+          run_install: false
+
+      - name: Get pnpm store directory
+        id: pnpm-cache
+        shell: bash
+        run: |
+          echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT
+
+      - name: Setup pnpm cache
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
+          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
+          restore-keys: |
+            ${{ runner.os }}-pnpm-store-
+
+      - name: Install dependencies
+        run: pnpm install --no-frozen-lockfile
+
+      - name: Run embeddings script
+        run: pnpm exec nx run tools-documentation-create-embeddings:run-node 
+        env:
+            NX_NEXT_PUBLIC_SUPABASE_URL: ${{ secrets.NX_NEXT_PUBLIC_SUPABASE_URL }}
+            NX_SUPABASE_SERVICE_ROLE_KEY: ${{ secrets.NX_SUPABASE_SERVICE_ROLE_KEY }}
+            NX_OPENAI_KEY: ${{ secrets.NX_OPENAI_KEY }}

.gitignore

@@ -19,7 +19,10 @@ jest.debug.config.js
 /graph/client/src/assets/generated-task-graphs
 /nx-dev/nx-dev/public/documentation
 /nx-dev/nx-dev/public/images/open-graph
+
+# Issues scraper creates these files, stored by github's cache
 /scripts/issues-scraper/cached
+
 # Lerna creates this
 CHANGELOG.md
 
@@ -34,3 +37,6 @@ CHANGELOG.md
 .bashrc
 
 *.node
+
+# Fix for issue when working on the repo in a dev container
+.pnpm-store

.verdaccio/config.yml

@@ -10,9 +10,13 @@ uplinks:
   npmjs:
     url: https://registry.npmjs.org/
     maxage: 60m
+    max_fails: 20
+    fail_timeout: 2m
   yarn:
     url: https://registry.yarnpkg.com
     maxage: 60m
+    max_fails: 20
+    fail_timeout: 2m
 
 packages:
   '@*/*':

CODEOWNERS

@@ -4,8 +4,8 @@
 /e2e/**/* @FrozenPandaz @vsavkin @AgentEnder @jaysoo @JamesHenry
 /scripts/**/* @FrozenPandaz @vsavkin @AgentEnder @jaysoo @JamesHenry
 /tools/**/* @FrozenPandaz @vsavkin @AgentEnder @jaysoo @JamesHenry
-package.json @nrwl/nx-pipelines-reviewers
-pnpm-lock.yaml @nrwl/nx-pipelines-reviewers
+package.json @nrwl/nx-core-reviewers
+pnpm-lock.yaml @nrwl/nx-core-reviewers
 
 # Docs Site + Graph
 /docs @nrwl/nx-docs-reviewers
@@ -36,7 +36,8 @@ pnpm-lock.yaml @nrwl/nx-pipelines-reviewers
 /e2e/react-core/** @nrwl/nx-react-reviewers
 /e2e/react-extensions/** @nrwl/nx-react-reviewers
 /packages/next/** @nrwl/nx-react-reviewers
-/e2e/next/** @nrwl/nx-react-reviewers
+/e2e/next-core/** @nrwl/nx-react-reviewers
+/e2e/next-extensions/** @nrwl/nx-react-reviewers
 /packages/react/plugins/component-testing/** @nrwl/nx-react-reviewers @nrwl/nx-testing-tools-reviewers
 /packages/react/src/generators/cypress-component-configuration/** @nrwl/nx-react-reviewers @nrwl/nx-testing-tools-reviewers
 /packages/react/src/generators/component-test/** @nrwl/nx-react-reviewers @nrwl/nx-testing-tools-reviewers
@@ -53,6 +54,10 @@ pnpm-lock.yaml @nrwl/nx-pipelines-reviewers
 /packages/react-native/** @nrwl/nx-react-reviewers
 /e2e/react-native/** @nrwl/nx-react-reviewers
 
+# Vue
+/packages/vue/** @nrwl/nx-vue-reviewers
+/e2e/vue/** @nrwl/nx-vue-reviewers
+
 ## Node
 /docs/generated/packages/node/** @nrwl/nx-node-reviewers @nrwl/nx-docs-reviewers
 /docs/generated/packages/nest/** @nrwl/nx-node-reviewers @nrwl/nx-docs-reviewers
@@ -155,13 +160,12 @@ pnpm-lock.yaml @nrwl/nx-pipelines-reviewers
 # Misc
 /e2e/lerna-smoke-tests/** @vsavkin @JamesHenry
 /e2e/utils/** @meeroslav @nrwl/nx-testing-tools-reviewers @vsavkin @mandarini
-/community @nrwl/nx-devkit-reviewers
+/community @nrwl/nx-docs-reviewers
 /CONTRIBUTING.md @FrozenPandaz @isaacplmann
 /CODE_OF_CONDUCT.md @FrozenPandaz @isaacplmann
 /CODEOWNERS @FrozenPandaz @AgentEnder
 
 # Scripts
-/scripts/depcheck @FrozenPandaz @vsavkin @jaysoo
 /scripts/documentation @nrwl/nx-docs-reviewers
 /scripts/angular-support-upgrades @nrwl/nx-angular-reviewers
 

CONTRIBUTING.md

@@ -76,13 +76,13 @@ Check out [this video for a live walkthrough](https://youtu.be/Tx257WpNsxc) or f
 - Run `pnpm local-registry` in Terminal 1 (keep it running)
 - Run `npm adduser --registry http://localhost:4873` in Terminal 2 (real credentials are not required, you just need to
   be logged in. You can use test/test/[email protected].)
-- Run `pnpm nx-release 16.0.0 --local` in Terminal 2 - you can choose any nonexistent version number here, but it's recommended to use the next major
+- Run `pnpm nx-release 17.0.0 --local` in Terminal 2 - you can choose any nonexistent version number here, but it's recommended to use the next major
 - Run `cd ./tmp` in Terminal 2
 - Run `npx [email protected]` in Terminal 2
 
 If you have problems publishing, make sure you use Node 18 and NPM 8.
 
-**NOTE:** To use this newly published local version, you need to make a new workspace or change all of your target packages to this new version, eg: `"nx": "^16.0.0",` and re-run `pnpm i` in your testing project.
+**NOTE:** To use this newly published local version, you need to make a new workspace or change all of your target packages to this new version, eg: `"nx": "^17.0.0",` and re-run `pnpm i` in your testing project.
 
 ### Publishing for Yarn 2+ (Berry)
 
@@ -343,7 +343,7 @@ Including the issue number that the PR relates to also helps with tracking.
 ```plain
 feat(angular): add an option to generate lazy-loadable modules
 
-`nx generate lib mylib --lazy` provisions the mylib project in tslint.json
+`nx generate lib mylib --lazy` provisions the mylib project in .eslintrc.json
 
 Closes #157
 ```