Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): provide more info for "findOriginalKeys is not a function" errors #16883

Merged
merged 1 commit into from
May 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/nx/src/plugins/js/lock-file/yarn-parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,13 @@ function mapSnapshots(

// collect snapshots and their matching keys
Object.values(nodes).forEach((node) => {
const [matchedKeys, snapshot] = findOriginalKeys(groupedDependencies, node);
const foundOriginalKeys = findOriginalKeys(groupedDependencies, node);
if (!foundOriginalKeys) {
throw new Error(
`Original key(s) not found for "${node.data.packageName}@${node.data.version}" while pruning yarn.lock.`
);
}
const [matchedKeys, snapshot] = foundOriginalKeys;
snapshotMap.set(snapshot, new Set(matchedKeys));

// separately save keys that still exist
Expand Down