Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): provide more info for "findOriginalKeys is not a function" errors #16883

Merged
merged 1 commit into from
May 10, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented May 9, 2023

Current Behavior

When pruning fails on yarn.lock is often fails with findOriginalKeys is not a function or its return value is not iterable because we can't map back to the original key. This gives us no information about which package failed to help us investigate further.

Expected Behavior

This error should return more information about which package is failing.

Related Issue(s)

Related to #16825 and #16875

@meeroslav meeroslav self-assigned this May 9, 2023
@meeroslav meeroslav requested a review from FrozenPandaz as a code owner May 9, 2023 11:02
@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 11:13am

@meeroslav meeroslav changed the title fix(core): provide more info for "findOriginalKeys is not a function"… fix(core): provide more info for "findOriginalKeys is not a function" errors May 9, 2023
@meeroslav meeroslav merged commit d26f26a into nrwl:master May 10, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants