Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump @actions/core to 1.10.0 #71

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

DaSchTour
Copy link
Contributor

@DaSchTour DaSchTour commented Oct 18, 2022

setOutput was changed and the old version triggers deprecation warnings

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaSchTour - I think for folks to be able to benefit from this, we'll want to turn this into a fix and therefore as part of this PR please bump the patch number in package.json. This will trigger the release workflow appropriately post-merge

- "version": "3.0.0", 
+  "version": "3.0.1",

setOutput was changed and the old version  triggers deprecation warnings
@DaSchTour DaSchTour force-pushed the update/actions-core-1.10.0 branch from 1a5823e to f0281e5 Compare October 25, 2022 15:00
@DaSchTour DaSchTour requested a review from JamesHenry October 25, 2022 15:01
@meeroslav meeroslav changed the title chore: bump @actions/core to 1.10.0 fix: bump @actions/core to 1.10.0 Oct 25, 2022
@meeroslav meeroslav self-requested a review October 25, 2022 15:18
Copy link
Collaborator

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! Thank you

Unfortunately it does not fix the #50 so we'll have to follow up on that.

@meeroslav meeroslav merged commit cbac28e into nrwl:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants