Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEP0005] DeprecationWarning: Buffer() is deprecated #50

Closed
iamstarkov opened this issue Jul 19, 2022 · 7 comments · Fixed by #77
Closed

[DEP0005] DeprecationWarning: Buffer() is deprecated #50

iamstarkov opened this issue Jul 19, 2022 · 7 comments · Fixed by #77

Comments

@iamstarkov
Copy link

Hello, in my GitHub actions with Node.js 16.16.0 build I see this error. I suspect it will stop working in the future.

(node:613) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[91](https://github.com/nordnet-private/nx-experiment/runs/7406784956?check_suite_focus=true#step:14:93)
(Use `node --trace-deprecation ...` to show where the warning was created)

Please take a look and let me know if you need any help of have any questions

@meeroslav
Copy link
Collaborator

Thank you @iamstarkov for reporting this.

We do not use Buffer directly. It's used via GitHub API tools. They might need to be updated. I will have a look.

@meeroslav
Copy link
Collaborator

Can you tell me which version of the nx-set-shas you are using?

@miluoshi
Copy link

I'm getting the same warning and I'm using latest version with tag nrwl/nx-set-shas@v2

@iamstarkov
Copy link
Author

@meeroslav
latest v2

Run nrwl/nx-set-shas@v2
[34](https://github.com/nordnet-private/monorepo-cms/runs/8092993037?check_suite_focus=true#step:9:35)
Run node $GITHUB_ACTION_PATH/dist/index.js *** master false push . 
[63](https://github.com/nordnet-private/monorepo-cms/runs/8092993037?check_suite_focus=true#step:9:64)
  
[63](https://github.com/nordnet-private/monorepo-cms/runs/8092993037?check_suite_focus=true#step:9:65)
(node:473) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[64](https://github.com/nordnet-private/monorepo-cms/runs/8092993037?check_suite_focus=true#step:9:66)
(Use `node --trace-deprecation ...` to show where the warning was created)

@Buckwich
Copy link

Here is the deprecation notice from github: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

So @actions/core needs to be updated to v1.10.0

@iamstarkov
Copy link
Author

@meeroslav is this issue still more info needed or is it actionable now?

@meeroslav
Copy link
Collaborator

This will be fixed with #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants