refactor: escape user input to prevent script injection #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayZeeDK
force-pushed
the
LayZeeDK/refactor/escape-input-to-prevent-script-injection
branch
2 times, most recently
from
2a277ec to
fbeeef0
Compare
Closed
* refactor: use run step condition Composite run steps have had support for conditions [since November 9th, 2021](https://github.blog/changelog/2021-11-09-github-actions-conditional-execution-of-steps-in-actions/). * chore: bump patch version
See [Understanding the risk of script injections](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#understanding-the-risk-of-script-injections).
…d line argument This is done to decrease the change of the GitHub token from appearing in any logs.
LayZeeDK
force-pushed
the
LayZeeDK/refactor/escape-input-to-prevent-script-injection
branch
from
d7d3012 to
cf45931
Compare
meeroslav
approved these changes
Sep 2, 2022
LayZeeDK
deleted the
LayZeeDK/refactor/escape-input-to-prevent-script-injection
branch
JamesHenry
added a commit
that referenced
this pull request
Sep 2, 2022
This reverts commit c1bcacc.
JamesHenry
added a commit
that referenced
this pull request
Sep 2, 2022
|
I have reverted this because it caused a lot of folks to break, please take a look at their comments on #59 |
meeroslav
pushed a commit
to meeroslav/nx-set-shas
that referenced
this pull request
Oct 26, 2022
* refactor: use run step condition (nrwl#55) * refactor: use run step condition Composite run steps have had support for conditions [since November 9th, 2021](https://github.blog/changelog/2021-11-09-github-actions-conditional-execution-of-steps-in-actions/). * chore: bump patch version * refactor: escape user inputs to prevent script injections See [Understanding the risk of script injections](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#understanding-the-risk-of-script-injections). * refactor: pass GitHub token as environment variable instead of command line argument This is done to decrease the change of the GitHub token from appearing in any logs. * refactor: use core API for logging to decrease the risk of secret leaks * chore: bump patch version (cherry picked from commit c1bcacc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security hardening