Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use run step condition #55

Merged

Conversation

LayZeeDK
Copy link
Contributor

Composite run steps have had support for conditions since November 9th, 2021.

@LayZeeDK LayZeeDK marked this pull request as ready for review August 31, 2022 22:50
@LayZeeDK LayZeeDK force-pushed the LayZeeDK/refactor/use-run-step-condition branch from b84840d to ef4ea14 Compare August 31, 2022 22:52
@meeroslav meeroslav merged commit eae3c65 into nrwl:main Sep 1, 2022
@meeroslav
Copy link
Collaborator

Thank you @LayZeeDK for this PR

@LayZeeDK LayZeeDK deleted the LayZeeDK/refactor/use-run-step-condition branch September 1, 2022 09:41
LayZeeDK added a commit to LayZeeDK/nrwl-nx-set-shas that referenced this pull request Sep 1, 2022
* refactor: use run step condition

Composite run steps have had support for conditions [since November 9th, 2021](https://github.blog/changelog/2021-11-09-github-actions-conditional-execution-of-steps-in-actions/).

* chore: bump patch version
@LayZeeDK LayZeeDK mentioned this pull request Sep 1, 2022
LayZeeDK added a commit to LayZeeDK/nrwl-nx-set-shas that referenced this pull request Sep 1, 2022
* refactor: use run step condition

Composite run steps have had support for conditions [since November 9th, 2021](https://github.blog/changelog/2021-11-09-github-actions-conditional-execution-of-steps-in-actions/).

* chore: bump patch version
meeroslav pushed a commit that referenced this pull request Sep 2, 2022
* refactor: use run step condition (#55)

* refactor: use run step condition

Composite run steps have had support for conditions [since November 9th, 2021](https://github.blog/changelog/2021-11-09-github-actions-conditional-execution-of-steps-in-actions/).

* chore: bump patch version

* refactor: escape user inputs to prevent script injections

See [Understanding the risk of script injections](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#understanding-the-risk-of-script-injections).

* refactor: pass GitHub token as environment variable instead of command line argument

This is done to decrease the change of the GitHub token from appearing in any logs.

* refactor: use core API for logging to decrease the risk of secret leaks

* chore: bump patch version
meeroslav pushed a commit to meeroslav/nx-set-shas that referenced this pull request Oct 26, 2022
* refactor: use run step condition (nrwl#55)

* refactor: use run step condition

Composite run steps have had support for conditions [since November 9th, 2021](https://github.blog/changelog/2021-11-09-github-actions-conditional-execution-of-steps-in-actions/).

* chore: bump patch version

* refactor: escape user inputs to prevent script injections

See [Understanding the risk of script injections](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#understanding-the-risk-of-script-injections).

* refactor: pass GitHub token as environment variable instead of command line argument

This is done to decrease the change of the GitHub token from appearing in any logs.

* refactor: use core API for logging to decrease the risk of secret leaks

* chore: bump patch version

(cherry picked from commit c1bcacc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants