Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openthread: kconfig: optimize FTD and MTD configurations #13012

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

maciejbaczmanski
Copy link
Member

@maciejbaczmanski maciejbaczmanski commented Nov 8, 2023

Removed support for:

  • DHCPv6 client
  • Joiner
  • SNTP client
  • Link Metrics initiator

in FTD and MTD variants to optimize space for application.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest labels Nov 8, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 8, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@6da1696 nrfconnect/sdk-connectedhomeip@1b16138 (master) nrfconnect/[email protected]
nrfxlib nrfconnect/sdk-nrfxlib@3266a76 nrfconnect/sdk-nrfxlib@8508941 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 8, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-fw-nrfconnect-thread X

test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@edmont edmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important enough change to update the changelog.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 9, 2023
@edmont edmont self-requested a review November 9, 2023 07:52
Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPENTHREAD_NORDIC_LIBRARY is mentioned in protocols/thread/overview/ot_memory.rst, does that mention need to change?

@maciejbaczmanski
Copy link
Member Author

OPENTHREAD_NORDIC_LIBRARY is mentioned in protocols/thread/overview/ot_memory.rst, does that mention need to change?

I've just found that OPENTHREAD_NORDIC_LIBRARY is used in code, so i've reverted the commit connected with that

@maciejbaczmanski
Copy link
Member Author

Discussion on DUA has been brought up to Thread Group, but will be continued separately. Reverted removing OPENTHREAD_DUA from this PR.

Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Could we please also fix the configuration on Matter side (i spotted it now) as a part of the same PR? Seems that we are enabling certain configs to be sure all is properly configured. I think we need to remove these overwrites:

https://github.com/nrfconnect/sdk-connectedhomeip/blob/599f334e6f865deb7ed452dbc7d63648f822094e/config/nrfconnect/chip-module/Kconfig.defaults#L344

https://github.com/nrfconnect/sdk-connectedhomeip/blob/599f334e6f865deb7ed452dbc7d63648f822094e/config/nrfconnect/chip-module/Kconfig.defaults#L365

Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@maciejbaczmanski maciejbaczmanski force-pushed the ot_optimizations branch 3 times, most recently from 0fb0f95 to dba1330 Compare November 22, 2023 13:16
maciejbaczmanski and others added 2 commits November 22, 2023 15:53
Removed support for:
- DHCPv6 client
- Joiner
- SNTP client
- Link Metrics initiator

in FTD and MTD variants to optimize space for application.

Co-authored-by: Łukasz Duda <[email protected]>
Signed-off-by: Maciej Baczmanski <[email protected]>
Update documentation and changelog regarding features
removed from feature sets.

Signed-off-by: Maciej Baczmanski <[email protected]>
@rlubos rlubos merged commit 3c4732c into nrfconnect:main Nov 22, 2023
14 of 15 checks passed
@maciejbaczmanski maciejbaczmanski deleted the ot_optimizations branch November 23, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-matter manifest-nrfxlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants