Skip to content

Commit

Permalink
nrf_wifi: Remove extra logline from log
Browse files Browse the repository at this point in the history 
The functions nrf_wifi_osal_log_err,
nrf_wifi_osal_log_info and nrf_wifi_osal_log_dbg use
log macros, which already adds newline.
No need to add "\n" in end of these function calls.
Remove "\n" from these function calls.

Signed-off-by: Kapil Bhatt <[email protected]>
  • Loading branch information
@kapbh @rlubos
kapbh authored and rlubos committed Nov 22, 2023
1 parent 370d551 commit 3266a76
Show file tree
Hide file tree
Showing 21 changed files with 439 additions and 439 deletions.
12 changes: 6 additions & 6 deletions nrf_wifi/bus_if/bal/src/bal.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ static void nrf_wifi_rpu_bal_sleep_chk(struct nrf_wifi_bal_dev_ctx *bal_ctx,

if ((sleep_reg_val & rpu_ps_state_mask) != rpu_ps_state_mask) {
nrf_wifi_osal_log_err(bal_ctx->bpriv->opriv,
"%s:RPU is being accessed when it is not ready !!! (Reg val = 0x%X)\n",
"%s:RPU is being accessed when it is not ready !!! (Reg val = 0x%X)",
__func__,
sleep_reg_val);
}
Expand All @@ -59,7 +59,7 @@ struct nrf_wifi_bal_dev_ctx *nrf_wifi_bal_dev_add(struct nrf_wifi_bal_priv *bpri

if (!bal_dev_ctx) {
nrf_wifi_osal_log_err(bpriv->opriv,
"%s: Unable to allocate bal_dev_ctx\n", __func__);
"%s: Unable to allocate bal_dev_ctx", __func__);
goto out;
}

Expand All @@ -71,7 +71,7 @@ struct nrf_wifi_bal_dev_ctx *nrf_wifi_bal_dev_add(struct nrf_wifi_bal_priv *bpri

if (!bal_dev_ctx->bus_dev_ctx) {
nrf_wifi_osal_log_err(bpriv->opriv,
"%s: Bus dev_add failed\n", __func__);
"%s: Bus dev_add failed", __func__);
goto out;
}

Expand Down Expand Up @@ -110,7 +110,7 @@ enum nrf_wifi_status nrf_wifi_bal_dev_init(struct nrf_wifi_bal_dev_ctx *bal_dev_

if (status != NRF_WIFI_STATUS_SUCCESS) {
nrf_wifi_osal_log_err(bal_dev_ctx->bpriv->opriv,
"%s: dev_init failed\n", __func__);
"%s: dev_init failed", __func__);
goto out;
}
out:
Expand Down Expand Up @@ -149,7 +149,7 @@ nrf_wifi_bal_init(struct nrf_wifi_osal_priv *opriv,

if (!bpriv) {
nrf_wifi_osal_log_err(opriv,
"%s: Unable to allocate memory for bpriv\n", __func__);
"%s: Unable to allocate memory for bpriv", __func__);
goto out;
}

Expand All @@ -165,7 +165,7 @@ nrf_wifi_bal_init(struct nrf_wifi_osal_priv *opriv,

if (!bpriv->bus_priv) {
nrf_wifi_osal_log_err(opriv,
"%s: Failed\n", __func__);
"%s: Failed", __func__);
nrf_wifi_osal_mem_free(opriv,
bpriv);
bpriv = NULL;
Expand Down
12 changes: 6 additions & 6 deletions nrf_wifi/bus_if/bus/qspi/src/qspi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ static void *nrf_wifi_bus_qspi_dev_add(void *bus_priv,

if (!qspi_dev_ctx) {
nrf_wifi_osal_log_err(qspi_priv->opriv,
"%s: Unable to allocate qspi_dev_ctx\n", __func__);
"%s: Unable to allocate qspi_dev_ctx", __func__);
goto out;
}

Expand All @@ -57,7 +57,7 @@ static void *nrf_wifi_bus_qspi_dev_add(void *bus_priv,

if (!qspi_dev_ctx->os_qspi_dev_ctx) {
nrf_wifi_osal_log_err(qspi_priv->opriv,
"%s: nrf_wifi_osal_bus_qspi_dev_add failed\n", __func__);
"%s: nrf_wifi_osal_bus_qspi_dev_add failed", __func__);

nrf_wifi_osal_mem_free(qspi_priv->opriv,
qspi_dev_ctx);
Expand All @@ -83,7 +83,7 @@ static void *nrf_wifi_bus_qspi_dev_add(void *bus_priv,

if (status != NRF_WIFI_STATUS_SUCCESS) {
nrf_wifi_osal_log_err(qspi_dev_ctx->qspi_priv->opriv,
"%s: Unable to register interrupt to the OS\n",
"%s: Unable to register interrupt to the OS",
__func__);

nrf_wifi_osal_bus_qspi_dev_intr_unreg(qspi_dev_ctx->qspi_priv->opriv,
Expand Down Expand Up @@ -134,7 +134,7 @@ static enum nrf_wifi_status nrf_wifi_bus_qspi_dev_init(void *bus_dev_ctx)

if (status != NRF_WIFI_STATUS_SUCCESS) {
nrf_wifi_osal_log_err(qspi_dev_ctx->qspi_priv->opriv,
"%s: nrf_wifi_osal_qspi_dev_init failed\n", __func__);
"%s: nrf_wifi_osal_qspi_dev_init failed", __func__);

goto out;
}
Expand Down Expand Up @@ -165,7 +165,7 @@ static void *nrf_wifi_bus_qspi_init(struct nrf_wifi_osal_priv *opriv,

if (!qspi_priv) {
nrf_wifi_osal_log_err(opriv,
"%s: Unable to allocate memory for qspi_priv\n",
"%s: Unable to allocate memory for qspi_priv",
__func__);
goto out;
}
Expand All @@ -183,7 +183,7 @@ static void *nrf_wifi_bus_qspi_init(struct nrf_wifi_osal_priv *opriv,

if (!qspi_priv->os_qspi_priv) {
nrf_wifi_osal_log_err(opriv,
"%s: Unable to register QSPI driver\n",
"%s: Unable to register QSPI driver",
__func__);

nrf_wifi_osal_mem_free(opriv,
Expand Down
12 changes: 6 additions & 6 deletions nrf_wifi/bus_if/bus/spi/src/spi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ static void *nrf_wifi_bus_spi_dev_add(void *bus_priv,

if (!spi_dev_ctx) {
nrf_wifi_osal_log_err(spi_priv->opriv,
"%s: Unable to allocate spi_dev_ctx\n", __func__);
"%s: Unable to allocate spi_dev_ctx", __func__);
goto out;
}

Expand All @@ -57,7 +57,7 @@ static void *nrf_wifi_bus_spi_dev_add(void *bus_priv,

if (!spi_dev_ctx->os_spi_dev_ctx) {
nrf_wifi_osal_log_err(spi_priv->opriv,
"%s: nrf_wifi_osal_bus_spi_dev_add failed\n", __func__);
"%s: nrf_wifi_osal_bus_spi_dev_add failed", __func__);

nrf_wifi_osal_mem_free(spi_priv->opriv,
spi_dev_ctx);
Expand All @@ -83,7 +83,7 @@ static void *nrf_wifi_bus_spi_dev_add(void *bus_priv,

if (status != NRF_WIFI_STATUS_SUCCESS) {
nrf_wifi_osal_log_err(spi_dev_ctx->spi_priv->opriv,
"%s: Unable to register interrupt to the OS\n",
"%s: Unable to register interrupt to the OS",
__func__);

nrf_wifi_osal_bus_spi_dev_intr_unreg(spi_dev_ctx->spi_priv->opriv,
Expand Down Expand Up @@ -131,7 +131,7 @@ static enum nrf_wifi_status nrf_wifi_bus_spi_dev_init(void *bus_dev_ctx)

if (status != NRF_WIFI_STATUS_SUCCESS) {
nrf_wifi_osal_log_err(spi_dev_ctx->spi_priv->opriv,
"%s: nrf_wifi_osal_spi_dev_init failed\n", __func__);
"%s: nrf_wifi_osal_spi_dev_init failed", __func__);

goto out;
}
Expand Down Expand Up @@ -162,7 +162,7 @@ static void *nrf_wifi_bus_spi_init(struct nrf_wifi_osal_priv *opriv,

if (!spi_priv) {
nrf_wifi_osal_log_err(opriv,
"%s: Unable to allocate memory for spi_priv\n",
"%s: Unable to allocate memory for spi_priv",
__func__);
goto out;
}
Expand All @@ -179,7 +179,7 @@ static void *nrf_wifi_bus_spi_init(struct nrf_wifi_osal_priv *opriv,
spi_priv->os_spi_priv = nrf_wifi_osal_bus_spi_init(opriv);
if (!spi_priv->os_spi_priv) {
nrf_wifi_osal_log_err(opriv,
"%s: Unable to register QSPI driver\n",
"%s: Unable to register QSPI driver",
__func__);

nrf_wifi_osal_mem_free(opriv,
Expand Down
28 changes: 14 additions & 14 deletions nrf_wifi/fw_if/umac_if/src/cmd.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ struct host_rpu_msg *umac_cmd_alloc(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx,

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: Failed to allocate UMAC cmd\n",
"%s: Failed to allocate UMAC cmd",
__func__);
goto out;
}
Expand All @@ -50,7 +50,7 @@ enum nrf_wifi_status umac_cmd_cfg(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx,

umac_hdr = (struct nrf_wifi_umac_hdr *)params;
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: UMAC buff config not yet done(%d)\n",
"%s: UMAC buff config not yet done(%d)",
__func__,
umac_hdr->cmd_evnt);
goto out;
Expand All @@ -62,7 +62,7 @@ enum nrf_wifi_status umac_cmd_cfg(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx,

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand All @@ -77,7 +77,7 @@ enum nrf_wifi_status umac_cmd_cfg(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx,
(sizeof(*umac_cmd) + len));

nrf_wifi_osal_log_dbg(fmac_dev_ctx->fpriv->opriv,
"%s: Command %d sent to RPU\n",
"%s: Command %d sent to RPU",
__func__,
((struct nrf_wifi_umac_hdr *)params)->cmd_evnt);

Expand Down Expand Up @@ -116,7 +116,7 @@ enum nrf_wifi_status umac_cmd_init(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx,

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down Expand Up @@ -149,7 +149,7 @@ enum nrf_wifi_status umac_cmd_init(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx,
umac_cmd_data->tcp_ip_checksum_offload = 1;
#endif /* CONFIG_NRF700X_TCP_IP_CHECKSUM_OFFLOAD */

nrf_wifi_osal_log_dbg(fmac_dev_ctx->fpriv->opriv, "RPU LPM type: %s\n",
nrf_wifi_osal_log_dbg(fmac_dev_ctx->fpriv->opriv, "RPU LPM type: %s",
umac_cmd_data->sys_params.sleep_enable == 2 ? "HW" :
umac_cmd_data->sys_params.sleep_enable == 1 ? "SW" : "DISABLED");
#ifndef CONFIG_NRF700X_RADIO_TEST
Expand Down Expand Up @@ -214,7 +214,7 @@ enum nrf_wifi_status umac_cmd_deinit(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx)
len);
if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down Expand Up @@ -245,7 +245,7 @@ enum nrf_wifi_status umac_cmd_btcoex(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx,

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down Expand Up @@ -288,7 +288,7 @@ enum nrf_wifi_status umac_cmd_he_ltf_gi(struct nrf_wifi_fmac_dev_ctx *fmac_dev_c

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down Expand Up @@ -338,7 +338,7 @@ enum nrf_wifi_status umac_cmd_prog_init(struct nrf_wifi_fmac_dev_ctx *fmac_dev_c

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down Expand Up @@ -377,7 +377,7 @@ enum nrf_wifi_status umac_cmd_prog_tx(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down Expand Up @@ -417,7 +417,7 @@ enum nrf_wifi_status umac_cmd_prog_rx(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down Expand Up @@ -458,7 +458,7 @@ enum nrf_wifi_status umac_cmd_prog_rf_test(struct nrf_wifi_fmac_dev_ctx *fmac_de

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down Expand Up @@ -504,7 +504,7 @@ enum nrf_wifi_status umac_cmd_prog_stats_get(struct nrf_wifi_fmac_dev_ctx *fmac_

if (!umac_cmd) {
nrf_wifi_osal_log_err(fmac_dev_ctx->fpriv->opriv,
"%s: umac_cmd_alloc failed\n",
"%s: umac_cmd_alloc failed",
__func__);
goto out;
}
Expand Down
Loading

0 comments on commit 3266a76

Please sign in to comment.