Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Docs: Remove note about prepublish not being run #17336

Closed
wants to merge 1 commit into from
Closed

Docs: Remove note about prepublish not being run #17336

wants to merge 1 commit into from

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Jun 20, 2017

See #16685

Removing the following note from the docs as the described change is not actually correct.

IMPORTANT: As of npm@5, prepublish will only be run for npm publish. This will make its behavior identical to prepublishOnly, so npm@6 or later may drop support for the use of prepublishOnly, and then maybe we can all forget this embarrassing thing ever happened.

Follows the change in #16918.

iarna pushed a commit that referenced this pull request Jun 27, 2017
@Hirse @iarna
docs: Remove note about prepublish not being run
8762988 
Credit: @Hirse
Fixes: #16685
Reviewed-By: @iarna
PR-URL: #17336
@iarna
Copy link
Contributor

iarna commented Jun 27, 2017

Thanks! This has been merged as 8762988.

@iarna iarna closed this Jun 27, 2017
@Hirse Hirse deleted the patch-1 branch June 27, 2017 14:58
@richvdh richvdh mentioned this pull request Jul 11, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hirse @iarna