Fix npm@5 bug when doing npm install

[MTRNord]

[email protected] droped support of prepublish for npm install. prepare replaces prepublish. See npm/npm#10074

[matrixbot]

Can one of the admins verify this patch?

[dbkr]

The only problem with this is that it will drop support for npm < 4, ie. node < 7.3.0

[turt2live]

It's worth noting that node 6 users can upgrade to npm 5 without issue.

[MTRNord]

Well maybe using both could help. Because for me is riot unusable in this case. Downgrade of npm is no option as I got another project where I use some newer features :/

[lukebarnard1]

Surely we just point "prepare" at "prepublish" and we're done? (as in literally "prepare": "npm run prepublish")

[turt2live]

That works until you have npm versions that haven't done the hard switch and try and do both:

• Prepublish
• Prepare
• Prepublish
• Prepare
• Prepublish
• ...

(Edit: I actually tried this, it is infinite)

[MTRNord]

Well you could just add the same as in prepublish to prepare. It would run them 2 times but not loop

[lukebarnard1]

The alternative for now is to use nvm for different npms with different projects.

[MTRNord]

@lukebarnard1 that works only on Linux. On windows you only have one version :/

[richvdh]

I'm clearly missing some context here, because when I do npm install with npm 5.0.3, it seems to run the prepublish script the same as it ever did. Indeed, things like npm/npm#17336 make me wonder if this change ever actually landed.

What am I missing?

[MTRNord]

@richvdh atleast on my windows maschine it did not run prepublish when it installs something as dependency.

[richvdh]

What version of npm?

[richvdh]

when it installs something as dependency.

Wait, that's expected. It's why the riot-web readme tells you to manually run npm i on the js-sdk and react-sdk.

Afaik npm does not run prepare in this situation either?

[MTRNord]

@richvdh well you not always need a full dev env. In that case you want it to build react-sdk or js-sdk anyway.

[richvdh]

@MTRNord I don't understand how this patch helps.

[MTRNord]

@richvdh for eexample if you quickly want to build the master of riot and don't want to pull every repo it is usually enough to just do npm install in riot-web. But doing so it has to run the prepublish script to build the needed files. with npm@5 and node8 as combination on windows that script never gets run. That causes the buid process to fail. You will eed to go in the node_modules folder and run npm run build in there to to get the needed compiled/transpiled js files. But yes this patch only works for npm>4 :/

[richvdh]

As I said in #riot-dev, you don't need to build the dependencies when setting up the master branch of riot-web.

@MTRNord said he would get back to me with details of what problem this actually solves.

[richvdh]

@MTRNord I'm going to close these until we understand what's going on here.