Release/v8.1.4 #4066
Merged
Release/v8.1.4 #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings us in line with the rest of the linting rules we are wanting to use on the npm cli repos. There were several hundred over-length lines and instead of editing them all by hand I piped the failing file through `prettier` and back through `eslint` just to save some time and energy. This means there may be some quirks in the linting those files have, but we can fix those if we see them and they bother us. Other than that there were about 50 lines that are legitimately over-length, all are now explicitly overridden. Many are tests that could be snapshots. PR-URL: #3995 Credit: @wraithgar Close: #3995 Reviewed-by: @lukekarrys
* Update to eslint@8 and and @npmcli/[email protected] * Remove eslint-plugin-node. Also remove an unused script that was failing linting. We don't use the update-dist-tags script anymore as part of our release process. PR-URL: #4016 Credit: @wraithgar Close: #4016 Reviewed-by: @lukekarrys
PR-URL: #4009 Credit: @danielcobo Close: #4009 Reviewed-by: @wraithgar
Uses the real npm object and doesn't mock anything. PR-URL: #4018 Credit: @wraithgar Close: #4018 Reviewed-by: @lukekarrys
These are never valid in the contexts from which this lib is called. Namely these are the bugs, docs, fund, help, and repo commands, and for oauth logins. PR-URL: #4025 Credit: @wraithgar Close: #4025 Reviewed-by: @isaacs
PR-URL: #4026 Credit: @wraithgar Close: #4026 Reviewed-by: @isaacs
Clean up tests too PR-URL: #4033 Credit: @wraithgar Close: #4033 Reviewed-by: @lukekarrys
Looks like tests were removed but the snapshots still have them. PR-URL: #4019 Credit: @wraithgar Close: #4019 Reviewed-by: @lukekarrys
The fake npm object in the tests wasn't returning an async function Fixes: #4020 PR-URL: #4032 Credit: @wraithgar Close: #4032 Reviewed-by: @lukekarrys
During a refactoring of the tests a bug was found in the install command completion that would return nothing if there was a valid match, this fixes that bug and also makes the tests actually test things. PR-URL: #4023 Credit: @wraithgar Close: #4023 Reviewed-by: @lukekarrys
now that we're off of node10 we can clean this up PR-URL: #3989 Credit: @wraithgar Close: #3989 Reviewed-by: @lukekarrys
Use a real npm object, actually assert things PR-URL: #4036 Credit: @wraithgar Close: #4036 Reviewed-by: @lukekarrys
* When rendering HTML documentation, don't use smart quotes because they're icky and hard to copy/paste. * Add a <!DOCTYPE html> and a <meta charset="utf-8"> to be good HTML citizens. PR-URL: #4046 Credit: @ethomson Close: #4046 Reviewed-by: @wraithgar
PR-URL: #4053 Credit: @MansurAliKoroglu Close: #4053 Reviewed-by: @wraithgar
PR-URL: #4050 Credit: @fritzy Close: #4050 Reviewed-by: @wraithgar PR-URL: #4050 Credit: @fritzy Close: #4050 Reviewed-by: @wraithgar
PR-URL: #4052 Credit: @isaacs Close: #4052 Reviewed-by: @wraithgar
PR-URL: #4049 Credit: @wraithgar Close: #4049 Reviewed-by: @fritzy
PR-URL: #4048 Credit: @wraithgar Close: #4048 Reviewed-by: @fritzy
* feat: support vs2022 * feat: build with config.gypi from node headers PR-URL: #4045 Credit: @wraithgar Close: #4045 Reviewed-by: @lukekarrys
PR-URL: #4065 Credit: @fritzy Close: #4065 Reviewed-by: @lukekarrys
lukekarrys
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8.1.4 (2021-11-18)
BUG FIXES
7887fb3d7#4025 fix: don't try to open file:/// urls (@wraithgar)cd6d3a90d#4026 fix: explicitly allownpm helpto open file:/// man pages (@wraithgar)72ca4a4e3#4020 #4032 fix: command completion (@wraithgar)b78949134#4023 fix(install): command completion with single match (@wraithgar)DEPENDENCIES
225645420#3995 update to latest eslint and linting rules (@wraithgar)203fedf5b#4016[email protected]:@npmcli/[email protected](@wraithgar)@npmcli/[email protected]7b4aa59b6[email protected]:,[email protected](@isaacs)08015859c#4049[email protected](@wraithgar)088c11694#4045[email protected]: (@wraithgar)44bfa3787#4065 @npmcli/arborist 4.0.5 (@fritzy)--no-workspaces