chore: refactor audit tests #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/audit-tests
branch
from
7e20958 to
fdb3e71
Compare
wraithgar
commented
Nov 10, 2021
| t.plan(1) | ||
| const { Npm } = mockNpm(t, { | ||
| 'npm-audit-report': (_, opts) => { | ||
| t.match(opts.reporter, 'json') |
There was a problem hiding this comment.
this test wasn't asserting anything? At least this is better than nothing but the real fix is to introduce nock to our tests and use that instead. Assert the actual end-to-end behaviour we want.
lukekarrys
approved these changes
Nov 10, 2021
Use a real npm object, actually assert things PR-URL: #4036 Credit: @wraithgar Close: #4036 Reviewed-by: @lukekarrys
wraithgar
force-pushed
the
gar/audit-tests
branch
from
fdb3e71 to
201df17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a real npm object, actually assert things